Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1484313003: [runtime] [proxy] Fix Object.prototype.propertyIsEnumerable to support proxies (Closed)

Created:
5 years ago by Camillo Bruni
Modified:
5 years ago
Reviewers:
neis, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] [proxy] Fix Object.prototype.PropertyIsEnumerable to support proxies. BUG=v8:1543 LOG=N Committed: https://crrev.com/df36d046a4b5e72a105fa2cbd370a1e0c8cf7b48 Cr-Commit-Position: refs/heads/master@{#32473}

Patch Set 1 #

Patch Set 2 : merging with master #

Patch Set 3 : more tests + proper argument conversion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -10 lines) Patch
M src/js/v8natives.js View 1 1 chunk +1 line, -8 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A test/mjsunit/harmony/proxies-property-is-enumerable.js View 1 2 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484313003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484313003/40001
5 years ago (2015-12-01 15:32:38 UTC) #2
Camillo Bruni
PTAL yet another proxy-specific bit in v8natives.js gone
5 years ago (2015-12-01 15:34:00 UTC) #4
Jakob Kummerow
lgtm
5 years ago (2015-12-01 15:58:51 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 15:59:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484313003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484313003/40001
5 years ago (2015-12-01 17:08:25 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-01 17:11:24 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-01 17:12:14 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/df36d046a4b5e72a105fa2cbd370a1e0c8cf7b48
Cr-Commit-Position: refs/heads/master@{#32473}

Powered by Google App Engine
This is Rietveld 408576698