Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: src/js/v8natives.js

Issue 1484313003: [runtime] [proxy] Fix Object.prototype.propertyIsEnumerable to support proxies (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: more tests + proper argument conversion Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/runtime/runtime-object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/v8natives.js
diff --git a/src/js/v8natives.js b/src/js/v8natives.js
index 711a22fe64ca8e0a43aecf2fe8aaed46bc066d14..97ace80ef8f2b9b81fb8029619e091827e7452af 100644
--- a/src/js/v8natives.js
+++ b/src/js/v8natives.js
@@ -207,16 +207,9 @@ function ObjectIsPrototypeOf(V) {
}
-// ECMA-262 - 15.2.4.6
+// ES6 19.1.3.4
function ObjectPropertyIsEnumerable(V) {
var P = TO_NAME(V);
- if (%_IsJSProxy(this)) {
- // TODO(rossberg): adjust once there is a story for symbols vs proxies.
- if (IS_SYMBOL(V)) return false;
-
- var desc = GetOwnPropertyJS(this, P);
- return IS_UNDEFINED(desc) ? false : desc.isEnumerable();
- }
return %IsPropertyEnumerable(TO_OBJECT(this), P);
}
« no previous file with comments | « no previous file | src/runtime/runtime-object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698