Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: components/autofill/content/renderer/autofill_agent.h

Issue 148413002: Add "previewing on hover" support for single-field autocomplete input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Ilya's 2nd set comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/autofill_agent.h
diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h
index 32d7b752f8807047487a6e43d8947a2f97aa5c7a..9ec288b758ad27a79b50f94bb185d68f03ef4c0f 100644
--- a/components/autofill/content/renderer/autofill_agent.h
+++ b/components/autofill/content/renderer/autofill_agent.h
@@ -105,7 +105,8 @@ class AutofillAgent : public content::RenderViewObserver,
void OnClearForm();
void OnSetAutofillActionPreview();
void OnClearPreviewedForm();
- void OnSetNodeText(const base::string16& value);
+ void OnFillFieldWithValue(const base::string16& value);
+ void OnPreviewFieldWithValue(const base::string16& value);
void OnAcceptDataListSuggestion(const base::string16& value);
void OnAcceptPasswordAutofillSuggestion(const base::string16& username);
@@ -171,7 +172,14 @@ class AutofillAgent : public content::RenderViewObserver,
FormFieldData* field) WARN_UNUSED_RESULT;
// Set |node| to display the given |value|.
- void SetNodeText(const base::string16& value, blink::WebInputElement* node);
+ void FillFieldWithValue(const base::string16& value,
+ blink::WebInputElement* node);
+
+ // Set |node| to display the given |value| as a preview. The preview is
+ // visible on screen to the user, but not visible to the page via the DOM or
+ // JavaScript.
+ void PreviewFieldWithValue(const base::string16& value,
+ blink::WebInputElement* node);
// Hides any currently showing Autofill popup.
void HidePopup();

Powered by Google App Engine
This is Rietveld 408576698