components/autofill/content/common/autofill_messages.h - Issue 148413002: Add "previewing on hover" support for single-field autocomplete input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 148413002: Add "previewing on hover" support for single-field autocomplete input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Ilya's 2nd set comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/browser/autofill_driver_impl_unittest.cc ('K') | « components/autofill/content/browser/autofill_driver_impl_unittest.cc ('k') | components/autofill/content/renderer/autofill_agent.h » ('j') | components/autofill/content/renderer/autofill_agent.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index a2b7b07307a255b7dddbfc39310638c8c9380f4a..5cc2b69fea20a6f46280da4f14acdd8eef332115 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -124,8 +124,12 @@ IPC_MESSAGE_ROUTED0(AutofillMsg_SetAutofillActionPreview)

IPC_MESSAGE_ROUTED0(AutofillMsg_ClearPreviewedForm)

// Sets the currently selected node's value.

-IPC_MESSAGE_ROUTED1(AutofillMsg_SetNodeText,

- base::string16 /* new node text */)

+IPC_MESSAGE_ROUTED1(AutofillMsg_FillFieldWithValue,

+ base::string16 /* value */)

+// Sets suggested value for the currently previewed node

Ilya Sherman 2014/03/01 02:57:37 nit: Please end the sentence with a period.

Tom Sepez 2014/03/03 19:28:46 nit: Sets the suggested value ...

ziran.sun 2014/03/04 15:30:19 Done.

+IPC_MESSAGE_ROUTED1(AutofillMsg_PreviewFieldWithValue,

+ base::string16 /* value */)

// Sets the currently selected node's value to be the given data list value.

IPC_MESSAGE_ROUTED1(AutofillMsg_AcceptDataListSuggestion,