Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

Issue 148413002: Add "previewing on hover" support for single-field autocomplete input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update code as per review comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_ 5 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
6 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_ 6 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
7 7
8 #include <set> 8 #include <set>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 virtual void LegalDocumentLinkClicked(const gfx::Range& range) OVERRIDE; 158 virtual void LegalDocumentLinkClicked(const gfx::Range& range) OVERRIDE;
159 virtual bool OnCancel() OVERRIDE; 159 virtual bool OnCancel() OVERRIDE;
160 virtual bool OnAccept() OVERRIDE; 160 virtual bool OnAccept() OVERRIDE;
161 virtual Profile* profile() OVERRIDE; 161 virtual Profile* profile() OVERRIDE;
162 virtual content::WebContents* GetWebContents() OVERRIDE; 162 virtual content::WebContents* GetWebContents() OVERRIDE;
163 163
164 // AutofillPopupDelegate implementation. 164 // AutofillPopupDelegate implementation.
165 virtual void OnPopupShown() OVERRIDE; 165 virtual void OnPopupShown() OVERRIDE;
166 virtual void OnPopupHidden() OVERRIDE; 166 virtual void OnPopupHidden() OVERRIDE;
167 virtual bool ShouldRepostEvent(const ui::MouseEvent& event) OVERRIDE; 167 virtual bool ShouldRepostEvent(const ui::MouseEvent& event) OVERRIDE;
168 virtual void DidSelectSuggestion(int identifier) OVERRIDE; 168 virtual void DidSelectSuggestion(int identifier,
169 const base::string16& value) OVERRIDE;
Ilya Sherman 2014/02/22 05:59:51 nit: Please update the parameters to have the same
ziran.sun 2014/02/27 15:38:11 Done.
169 virtual void DidAcceptSuggestion(const base::string16& value, 170 virtual void DidAcceptSuggestion(const base::string16& value,
170 int identifier) OVERRIDE; 171 int identifier) OVERRIDE;
171 virtual void RemoveSuggestion(const base::string16& value, 172 virtual void RemoveSuggestion(const base::string16& value,
172 int identifier) OVERRIDE; 173 int identifier) OVERRIDE;
173 virtual void ClearPreviewedForm() OVERRIDE; 174 virtual void ClearPreviewedForm() OVERRIDE;
174 175
175 // content::NotificationObserver implementation. 176 // content::NotificationObserver implementation.
176 virtual void Observe(int type, 177 virtual void Observe(int type,
177 const content::NotificationSource& source, 178 const content::NotificationSource& source,
178 const content::NotificationDetails& details) OVERRIDE; 179 const content::NotificationDetails& details) OVERRIDE;
(...skipping 620 matching lines...) Expand 10 before | Expand all | Expand 10 after
799 base::string16 submitted_cardholder_name_; 800 base::string16 submitted_cardholder_name_;
800 801
801 base::WeakPtrFactory<AutofillDialogControllerImpl> weak_ptr_factory_; 802 base::WeakPtrFactory<AutofillDialogControllerImpl> weak_ptr_factory_;
802 803
803 DISALLOW_COPY_AND_ASSIGN(AutofillDialogControllerImpl); 804 DISALLOW_COPY_AND_ASSIGN(AutofillDialogControllerImpl);
804 }; 805 };
805 806
806 } // namespace autofill 807 } // namespace autofill
807 808
808 #endif // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_ 809 #endif // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698