Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 1484093002: Allowing multiple SaveItems to have same URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nested-frames-more-involved-fix
Patch Set: Rebasing... Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/save_page_browsertest.cc
diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc
index eeacdc6f6b9901cfaf0b2114adfe895882d56893..23595b3396638cd6f0a7eb8eb9c5a8c33d58d9a8 100644
--- a/chrome/browser/download/save_page_browsertest.cc
+++ b/chrome/browser/download/save_page_browsertest.cc
@@ -1072,6 +1072,26 @@ IN_PROC_BROWSER_TEST_P(SavePageMultiFrameBrowserTest, NestedFrames) {
TestMultiFramePage(save_page_type, url, 3, expected_substrings);
}
+IN_PROC_BROWSER_TEST_P(SavePageMultiFrameBrowserTest, RuntimeChanges) {
+ content::SavePageType save_page_type = GetParam();
+
+ std::vector<std::string> expected_substrings{
+ "frames-runtime-changes.htm: 396f17f2-2c48-4793-a570-bc856e66e75d",
+ // TODO(lukasza): Need to avoid uri-based deduping (which currently
+ // happens in a map from uris into local paths.
+ // "subframe1: 21595339-61fc-4854-b6df-0668328ea263",
+ // "subframe2: adf55719-15e7-45be-9eda-d12fe782a1bd",
+ // TODO(lukasza): Need to also fix inline / srcdoc frames.
+ // "subframe3: 50e294bf-3a5b-499d-8772-651ead26952f",
+ // "subframe4: e0ea9289-7467-4d32-ba5c-c604e8d84cb7",
+ };
+
+ GURL url(embedded_test_server()->GetURL(
+ "a.com", "/save_page/frames-runtime-changes.htm?do_runtime_changes=1"));
+
+ TestMultiFramePage(save_page_type, url, 5, expected_substrings);
+}
+
INSTANTIATE_TEST_CASE_P(
SaveType,
SavePageMultiFrameBrowserTest,
« no previous file with comments | « no previous file | chrome/test/data/save_page/frames-runtime-changes.htm » ('j') | content/browser/download/save_item.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698