chrome/test/data/save_page/frames-runtime-changes.htm - Issue 1484093002: Allowing multiple SaveItems to have same URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/save_page/frames-runtime-changes.htm

Issue 1484093002: Allowing multiple SaveItems to have same URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nested-frames-more-involved-fix

Patch Set: Rebasing... Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/save_page/frames-runtime-changes.htm

diff --git a/chrome/test/data/save_page/frames-runtime-changes.htm b/chrome/test/data/save_page/frames-runtime-changes.htm

new file mode 100644

index 0000000000000000000000000000000000000000..2413993d929449b21c87a639661f84473fe7ab43

--- /dev/null

+++ b/chrome/test/data/save_page/frames-runtime-changes.htm

@@ -0,0 +1,74 @@

+<!doctype html>

+<html>

+ <head>

+ <script type="text/javascript">

+function addNewMarker(elementId, marker) {

+ f = document.getElementById(elementId)

+ f.contentDocument.body.innerHTML = elementId + ": " + marker

+function onLoad() {

+ if (location.href.indexOf("do_runtime_changes") == (-1))

+ return

+ addNewMarker("subframe1", "21595339-61fc-4854-b6df-0668328ea263")

+ addNewMarker("subframe2", "adf55719-15e7-45be-9eda-d12fe782a1bd")

+ addNewMarker("subframe3", "50e294bf-3a5b-499d-8772-651ead26952f")

+ addNewMarker("subframe4", "e0ea9289-7467-4d32-ba5c-c604e8d84cb7")

+ </script>

+ </head>

+ <body onload="onLoad()">

+ <h1>Test page features</h1>

+ IFrames below have the same URI, but JavaScript will change their

+ contents - the saved page should preserve this difference in

+ contents of the IFrames.

+ <h1>Test content</h1>

+ Content verification marker:

+ frames-runtime-changes.htm: 396f17f2-2c48-4793-a570-bc856e66e75d

+ <br>

+ Frames with orignal content fetched via "src" attribute:

+ <br>

+ <iframe id="subframe1" src="b.htm"></iframe>

+ <br>

+ <iframe id="subframe2" src="b.htm"></iframe>

+ <br>

+ Frames with orignal content defined via "srcdoc" attribute:

+ <br>

+ <iframe id="subframe3" srcdoc="

+ <html>

+ <head>

+ <title>subtitle3</title>

+ </head>

+ <body>

+ srcdoc3: bd191e37-1797-41a4-9e25-a732d988b255

+ <br>

+ </body>

+ </html>"></iframe>

+ <br>

+ <iframe id="subframe4" srcdoc="

+ <html>

+ <head>

+ <title>subtitle4</title>

+ </head>

+ <body>

+ srcdoc4: c60fa69e-20a8-4cb0-ad9d-122355fe2522

+ <br>

+ </body>

+ </html>"></iframe>

+ <br>

+ </body>

+</html>

« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | content/browser/download/save_file.h » ('j') | content/browser/download/save_item.cc » ('J')