Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1484083005: Invalidate visited state changes for svg links. (Closed)

Created:
5 years ago by rune
Modified:
5 years ago
Reviewers:
fs
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Invalidate visited state changes for svg links. SVGAElement only caused :link/:visited recalcs when it became a link or stopped being so. Now recalculate style whenever href changes in case the :visited/:link state changes. Also use style invalidation instead of SubtreeStyleChange, as the latter entails sibling forest recalc in case we have adjacent combinators. R=fs@opera.com BUG=563485, 557440 Committed: https://crrev.com/a20490516fb1ec4aa983bd233b261689417de64e Cr-Commit-Position: refs/heads/master@{#362425}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/svg/css/anchor-change-href.svg View 1 chunk +43 lines, -0 lines 1 comment Download
A third_party/WebKit/LayoutTests/svg/css/anchor-change-href-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAElement.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484083005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484083005/1
5 years ago (2015-12-01 13:06:48 UTC) #2
rune
5 years ago (2015-12-01 13:07:21 UTC) #3
fs
lgtm https://codereview.chromium.org/1484083005/diff/1/third_party/WebKit/LayoutTests/svg/css/anchor-change-href.svg File third_party/WebKit/LayoutTests/svg/css/anchor-change-href.svg (right): https://codereview.chromium.org/1484083005/diff/1/third_party/WebKit/LayoutTests/svg/css/anchor-change-href.svg#newcode28 third_party/WebKit/LayoutTests/svg/css/anchor-change-href.svg:28: // The elementCount should have been 2, but ...
5 years ago (2015-12-01 13:32:58 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 14:21:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484083005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484083005/1
5 years ago (2015-12-01 14:42:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484083005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484083005/1
5 years ago (2015-12-01 15:04:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 16:29:20 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-01 16:30:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a20490516fb1ec4aa983bd233b261689417de64e
Cr-Commit-Position: refs/heads/master@{#362425}

Powered by Google App Engine
This is Rietveld 408576698