third_party/WebKit/Source/core/svg/SVGAElement.cpp - Issue 1484083005: Invalidate visited state changes for svg links.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGAElement.cpp

Issue 1484083005: Invalidate visited state changes for svg links. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGAElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGAElement.cpp b/third_party/WebKit/Source/core/svg/SVGAElement.cpp

index 78e42e7adfc455a512be62aba6f0f4035dac54e1..2251192ad5dbd3d0a310e417cdac7c359dc2c31b 100644

--- a/third_party/WebKit/Source/core/svg/SVGAElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGAElement.cpp

@@ -91,9 +91,11 @@ void SVGAElement::svgAttributeChanged(const QualifiedName& attrName)

bool wasLink = isLink();

setIsLink(!hrefString().isNull());

- if (wasLink != isLink())

- setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::LinkColorChange));

+ if (wasLink || isLink()) {

+ pseudoStateChanged(CSSSelector::PseudoLink);

+ pseudoStateChanged(CSSSelector::PseudoVisited);

+ pseudoStateChanged(CSSSelector::PseudoAnyLink);

+ }

return;

}