Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1483993002: [heap] Aggressive code flushing in GC stress mode. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-code-flushing-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Aggressive code flushing in GC stress mode. This disregards the code age heuristic when deciding whether to flush code so that GC stress mode is more likely to flush out potential races between our various "invariants". R=hpayer@chromium.org Committed: https://crrev.com/28a3f23e50f1847dd1152e6bb4aa0579acbdaaab Cr-Commit-Position: refs/heads/master@{#32414}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/heap/objects-visiting-inl.h View 2 chunks +10 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years ago (2015-11-30 15:52:20 UTC) #1
Hannes Payer (out of office)
lgtm
5 years ago (2015-11-30 17:01:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483993002/1
5 years ago (2015-11-30 17:17:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 17:24:09 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/28a3f23e50f1847dd1152e6bb4aa0579acbdaaab Cr-Commit-Position: refs/heads/master@{#32414}
5 years ago (2015-11-30 17:24:27 UTC) #7
Michael Starzinger
5 years ago (2015-11-30 19:09:28 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1485823002/ by mstarzinger@chromium.org.

The reason for reverting is: This breaks (surprise) GC stress with custom
snapshot, cannot reproduce, will need to investigate further.

https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20...
.

Powered by Google App Engine
This is Rietveld 408576698