Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1482363002: [heap] JSFunction::context always points to valid context. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] JSFunction::context always points to valid context. This removes an overly complex predicate from the IsFlushable check within the marking visitor. By now all JSFunction objects reference a valid Context object, also builtin functions can be recognized without looking at the JSFunction object. R=hpayer@chromium.org Committed: https://crrev.com/252bb3a8a0cabae1cb943e00ff9beefb0c7a221f Cr-Commit-Position: refs/heads/master@{#32412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M src/heap/objects-visiting-inl.h View 3 chunks +5 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years ago (2015-11-30 15:38:36 UTC) #1
Hannes Payer (out of office)
lgtm
5 years ago (2015-11-30 17:00:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482363002/1
5 years ago (2015-11-30 17:01:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 17:06:32 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-30 17:07:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/252bb3a8a0cabae1cb943e00ff9beefb0c7a221f
Cr-Commit-Position: refs/heads/master@{#32412}

Powered by Google App Engine
This is Rietveld 408576698