Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1483933002: Deprecate unused RelocInfo::CONSTRUCT_CALL mode. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Deprecate unused RelocInfo::CONSTRUCT_CALL mode. R=bmeurer@chromium.org Committed: https://crrev.com/269ff36d9f2dd4a4b2872215ed356385fd451ac8 Cr-Commit-Position: refs/heads/master@{#32403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -93 lines) Patch
M src/arm/builtins-arm.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/assembler.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/assembler.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/disassembler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/mips/builtins-mips.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ppc/builtins-ppc.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/x87/builtins-x87.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years ago (2015-11-30 11:56:23 UTC) #1
Benedikt Meurer
Awesome. LGTM!
5 years ago (2015-11-30 11:57:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483933002/1
5 years ago (2015-11-30 12:32:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 12:38:59 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-30 12:39:44 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/269ff36d9f2dd4a4b2872215ed356385fd451ac8
Cr-Commit-Position: refs/heads/master@{#32403}

Powered by Google App Engine
This is Rietveld 408576698