Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: src/assembler.cc

Issue 1483933002: Deprecate unused RelocInfo::CONSTRUCT_CALL mode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/assembler.h ('k') | src/crankshaft/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 781 matching lines...) Expand 10 before | Expand all | Expand 10 after
792 792
793 #ifdef ENABLE_DISASSEMBLER 793 #ifdef ENABLE_DISASSEMBLER
794 const char* RelocInfo::RelocModeName(RelocInfo::Mode rmode) { 794 const char* RelocInfo::RelocModeName(RelocInfo::Mode rmode) {
795 switch (rmode) { 795 switch (rmode) {
796 case NONE32: 796 case NONE32:
797 return "no reloc 32"; 797 return "no reloc 32";
798 case NONE64: 798 case NONE64:
799 return "no reloc 64"; 799 return "no reloc 64";
800 case EMBEDDED_OBJECT: 800 case EMBEDDED_OBJECT:
801 return "embedded object"; 801 return "embedded object";
802 case CONSTRUCT_CALL:
803 return "code target (js construct call)";
804 case DEBUGGER_STATEMENT: 802 case DEBUGGER_STATEMENT:
805 return "debugger statement"; 803 return "debugger statement";
806 case CODE_TARGET: 804 case CODE_TARGET:
807 return "code target"; 805 return "code target";
808 case CODE_TARGET_WITH_ID: 806 case CODE_TARGET_WITH_ID:
809 return "code target with id"; 807 return "code target with id";
810 case CELL: 808 case CELL:
811 return "property cell"; 809 return "property cell";
812 case RUNTIME_ENTRY: 810 case RUNTIME_ENTRY:
813 return "runtime entry"; 811 return "runtime entry";
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
894 #ifdef VERIFY_HEAP 892 #ifdef VERIFY_HEAP
895 void RelocInfo::Verify(Isolate* isolate) { 893 void RelocInfo::Verify(Isolate* isolate) {
896 switch (rmode_) { 894 switch (rmode_) {
897 case EMBEDDED_OBJECT: 895 case EMBEDDED_OBJECT:
898 Object::VerifyPointer(target_object()); 896 Object::VerifyPointer(target_object());
899 break; 897 break;
900 case CELL: 898 case CELL:
901 Object::VerifyPointer(target_cell()); 899 Object::VerifyPointer(target_cell());
902 break; 900 break;
903 case DEBUGGER_STATEMENT: 901 case DEBUGGER_STATEMENT:
904 case CONSTRUCT_CALL:
905 case CODE_TARGET_WITH_ID: 902 case CODE_TARGET_WITH_ID:
906 case CODE_TARGET: { 903 case CODE_TARGET: {
907 // convert inline target address to code object 904 // convert inline target address to code object
908 Address addr = target_address(); 905 Address addr = target_address();
909 CHECK(addr != NULL); 906 CHECK(addr != NULL);
910 // Check that we can find the right code object. 907 // Check that we can find the right code object.
911 Code* code = Code::GetCodeFromTargetAddress(addr); 908 Code* code = Code::GetCodeFromTargetAddress(addr);
912 Object* found = isolate->FindCodeObject(addr); 909 Object* found = isolate->FindCodeObject(addr);
913 CHECK(found->IsCode()); 910 CHECK(found->IsCode());
914 CHECK(code->address() == HeapObject::cast(found)->address()); 911 CHECK(code->address() == HeapObject::cast(found)->address());
(...skipping 980 matching lines...) Expand 10 before | Expand all | Expand 10 after
1895 1892
1896 1893
1897 void Assembler::DataAlign(int m) { 1894 void Assembler::DataAlign(int m) {
1898 DCHECK(m >= 2 && base::bits::IsPowerOfTwo32(m)); 1895 DCHECK(m >= 2 && base::bits::IsPowerOfTwo32(m));
1899 while ((pc_offset() & (m - 1)) != 0) { 1896 while ((pc_offset() & (m - 1)) != 0) {
1900 db(0); 1897 db(0);
1901 } 1898 }
1902 } 1899 }
1903 } // namespace internal 1900 } // namespace internal
1904 } // namespace v8 1901 } // namespace v8
OLDNEW
« no previous file with comments | « src/assembler.h ('k') | src/crankshaft/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698