Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 1483903004: tools/gn: move the implementation of IsIdentifierXXX functions to the source file (Closed)

Created:
5 years ago by tfarina
Modified:
5 years ago
Reviewers:
scottmg
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/gn: move the implementation of IsIdentifierXXX functions to the source file Does not seem to have a reason to have some functions implemented in the header while the others are in the source file. This also allow us to remove the include of string_util.h, and have it included only in the source file. BUG=None R=scottmg@chromium.org Committed: https://crrev.com/0c60e3a9bb46ef9f3cf92f90f3e6fde598f3b8ee Cr-Commit-Position: refs/heads/master@{#362285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M tools/gn/command_format.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/tokenizer.h View 2 chunks +2 lines, -8 lines 0 comments Download
M tools/gn/tokenizer.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
PTAL
5 years ago (2015-11-30 22:14:46 UTC) #1
scottmg
lgtm
5 years ago (2015-11-30 22:25:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483903004/1
5 years ago (2015-11-30 23:37:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 00:10:57 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-01 00:12:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c60e3a9bb46ef9f3cf92f90f3e6fde598f3b8ee
Cr-Commit-Position: refs/heads/master@{#362285}

Powered by Google App Engine
This is Rietveld 408576698