Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tools/gn/tokenizer.h

Issue 1483903004: tools/gn: move the implementation of IsIdentifierXXX functions to the source file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/command_format.cc ('k') | tools/gn/tokenizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/tokenizer.h
diff --git a/tools/gn/tokenizer.h b/tools/gn/tokenizer.h
index 5fa48b1a493aa216c9726549dc328d718b3e8145..a37f4dc882f55b064627083430835fd8f35f18a3 100644
--- a/tools/gn/tokenizer.h
+++ b/tools/gn/tokenizer.h
@@ -9,7 +9,6 @@
#include "base/macros.h"
#include "base/strings/string_piece.h"
-#include "base/strings/string_util.h"
#include "tools/gn/err.h"
#include "tools/gn/token.h"
@@ -32,14 +31,9 @@ class Tokenizer {
// The offset must be in the buffer.
static bool IsNewline(const base::StringPiece& buffer, size_t offset);
- static bool IsIdentifierFirstChar(char c) {
- return base::IsAsciiAlpha(c) || c == '_';
- }
+ static bool IsIdentifierFirstChar(char c);
- static bool IsIdentifierContinuingChar(char c) {
- // Also allow digits after the first char.
- return IsIdentifierFirstChar(c) || base::IsAsciiDigit(c);
- }
+ static bool IsIdentifierContinuingChar(char c);
private:
// InputFile must outlive the tokenizer and all generated tokens.
« no previous file with comments | « tools/gn/command_format.cc ('k') | tools/gn/tokenizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698