Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Unified Diff: content/renderer/pepper/pepper_webplugin_impl.cc

Issue 1483733002: Remove support for NPObjects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/pepper_webplugin_impl.cc
diff --git a/content/renderer/pepper/pepper_webplugin_impl.cc b/content/renderer/pepper/pepper_webplugin_impl.cc
index 7c4e04de0c9078c8157b46b465c45ad72e6e4640..98460629a28f832898091ee3d446b24f66d28547 100644
--- a/content/renderer/pepper/pepper_webplugin_impl.cc
+++ b/content/renderer/pepper/pepper_webplugin_impl.cc
@@ -23,7 +23,6 @@
#include "third_party/WebKit/public/platform/WebRect.h"
#include "third_party/WebKit/public/platform/WebSize.h"
#include "third_party/WebKit/public/platform/WebURLLoaderClient.h"
-#include "third_party/WebKit/public/web/WebBindings.h"
#include "third_party/WebKit/public/web/WebDocument.h"
#include "third_party/WebKit/public/web/WebElement.h"
#include "third_party/WebKit/public/web/WebFrame.h"
@@ -97,9 +96,6 @@ bool PepperWebPluginImpl::initialize(WebPluginContainer* container) {
if (!instance_.get())
return false;
- // Enable script objects for this plugin.
- container->allowScriptObjects();
Wez 2016/01/14 21:57:08 We should also remove pp::deprecated::ScriptableOb
dcheng 2016/01/14 22:05:50 I thought Flash used it. I could be wrong.
-
auto weak_this = weak_factory_.GetWeakPtr();
bool success =
instance_->Initialize(init_data_->arg_names, init_data_->arg_values,
@@ -150,12 +146,6 @@ bool PepperWebPluginImpl::initialize(WebPluginContainer* container) {
}
void PepperWebPluginImpl::destroy() {
- // Tell |container_| to clear references to this plugin's script objects.
- if (container_)
- container_->clearScriptObjects();
-
- container_ = nullptr;
-
if (instance_.get()) {
ppapi::PpapiGlobals::Get()->GetVarTracker()->ReleaseVar(instance_object_);
instance_object_ = PP_MakeUndefined();

Powered by Google App Engine
This is Rietveld 408576698