Remove support for NPObjects.

content/renderer/pepper/pepper_webplugin_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_webplugin_impl.h"
 
 #include <stddef.h>
 #include <cmath>
 #include <utility>
 
 #include "base/debug/crash_logging.h"
 #include "base/message_loop/message_loop.h"
 #include "content/public/renderer/content_renderer_client.h"
 #include "content/renderer/pepper/message_channel.h"
 #include "content/renderer/pepper/pepper_plugin_instance_impl.h"
 #include "content/renderer/pepper/plugin_instance_throttler_impl.h"
 #include "content/renderer/pepper/plugin_module.h"
 #include "content/renderer/pepper/v8object_var.h"
 #include "content/renderer/render_frame_impl.h"
 #include "ppapi/shared_impl/ppapi_globals.h"
 #include "ppapi/shared_impl/var_tracker.h"
 #include "third_party/WebKit/public/platform/WebPoint.h"
 #include "third_party/WebKit/public/platform/WebRect.h"
 #include "third_party/WebKit/public/platform/WebSize.h"
 #include "third_party/WebKit/public/platform/WebURLLoaderClient.h"
-#include "third_party/WebKit/public/web/WebBindings.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebElement.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
 #include "third_party/WebKit/public/web/WebPluginContainer.h"
 #include "third_party/WebKit/public/web/WebPluginParams.h"
 #include "third_party/WebKit/public/web/WebPrintParams.h"
 #include "third_party/WebKit/public/web/WebPrintPresetOptions.h"
 #include "third_party/WebKit/public/web/WebPrintScalingOption.h"
 #include "url/gurl.h"
 
@@ skipping 53 matching lines @@
   return container_;
 }
 
 bool PepperWebPluginImpl::initialize(WebPluginContainer* container) {
   // The plugin delegate may have gone away.
   instance_ = init_data_->module->CreateInstance(
       init_data_->render_frame, container, init_data_->url);
   if (!instance_.get())
     return false;
 
-  // Enable script objects for this plugin.
-  container->allowScriptObjects();

[Wez, 2016/01/14 21:57:08]

We should also remove pp::deprecated::ScriptableObject, pp::deprecated::Var and
friends, which are the PPAPI-side counterparts to this glue.

[dcheng, 2016/01/14 22:05:50]

I thought Flash used it. I could be wrong.

-
   auto weak_this = weak_factory_.GetWeakPtr();
   bool success =
       instance_->Initialize(init_data_->arg_names, init_data_->arg_values,
                             full_frame_, std::move(throttler_));
   // The above call to Initialize can result in re-entrancy and destruction of
   // the plugin instance. In this case it's quite unclear whether this object
   // could also have been destroyed. We could return false here, but it would be
   // better if this object was guaranteed to outlast the recursive call.
   // Otherwise, the caller of this function would also have to take care that,
   // in the case of the object being deleted, we never access it again, and we
@@ skipping 30 matching lines @@
     return true;
   }
 
   init_data_.reset();
   CHECK(container->plugin() == this);
   container_ = container;
   return true;
 }
 
 void PepperWebPluginImpl::destroy() {
-  // Tell |container_| to clear references to this plugin's script objects.
-  if (container_)
-    container_->clearScriptObjects();
-
-  container_ = nullptr;
-
   if (instance_.get()) {
     ppapi::PpapiGlobals::Get()->GetVarTracker()->ReleaseVar(instance_object_);
     instance_object_ = PP_MakeUndefined();
     instance_->Delete();
     instance_ = NULL;
   }
 
   base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);
 }
 
@@ skipping 145 matching lines @@
 
 bool PepperWebPluginImpl::canRotateView() { return instance_->CanRotateView(); }
 
 void PepperWebPluginImpl::rotateView(RotationType type) {
   instance_->RotateView(type);
 }
 
 bool PepperWebPluginImpl::isPlaceholder() { return false; }
 
 }  // namespace content