ozone: support gfx::BufferFormat::RGBX_8888 as a native pixmap format.

ui/ozone/platform/drm/gpu/gbm_buffer_base.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/platform/drm/gpu/gbm_buffer_base.h"
 
 #include <gbm.h>
 
 #include "base/logging.h"
 #include "ui/ozone/platform/drm/gpu/drm_device.h"
 
 namespace ui {
 
 GbmBufferBase::GbmBufferBase(const scoped_refptr<DrmDevice>& drm,
                              gbm_bo* bo,
                              bool scanout)
     : drm_(drm), bo_(bo) {
+  fb_pixel_format_ = gbm_bo_get_format(bo);

[dshwang, 2015/11/27 17:59:54]

fb_pixel_format_ is used in GetBufferFormat() even for GPU_READ_WRITE buffer.

[reveman, 2015/11/27 20:09:33]

can you move this into the initialization list? 

[kalyank, 2015/11/27 21:15:20]

Here storage format can be different to pixel format. This is not something
OverlayCandidateHost can decide as it’s very specific to how we register the
framebuffer. Currently, we always create fb of 24 bitcolordepth.
GetFramebufferPixelFormat returns the Frame buffer format for this buffer.
GetBufferFormat should return the pixel format, we could just query it directly
from gbm there? If we want to cache the value than we need to separate it from
fb_pixel_format_

   if (scanout) {
-    fb_pixel_format_ = gbm_bo_get_format(bo);
-    if (fb_pixel_format_ == GBM_FORMAT_ARGB8888)
-      fb_pixel_format_ = GBM_FORMAT_XRGB8888;

[dshwang, 2015/11/27 17:59:54]

This hack was introduced by https://codereview.chromium.org/1314553002
Choosing XRGB or XRGB is role of drm_overlay_candidates_hosts, not here.

It causes crash of gl_unittests in 
https://code.google.com/p/chromium/codesearch#chromium/src/ui/ozone/platform/...

-
-    // For now, we only support XRGB and UYVY format.
-    DCHECK(fb_pixel_format_ == GBM_FORMAT_XRGB8888 ||
-           fb_pixel_format_ == GBM_FORMAT_UYVY);
-
     uint32_t handles[4] = {0};
     handles[0] = gbm_bo_get_handle(bo).u32;
     uint32_t strides[4] = {0};
     strides[0] = gbm_bo_get_stride(bo);
     uint32_t offsets[4] = {0};
 
     if (!drm_->AddFramebuffer2(gbm_bo_get_width(bo), gbm_bo_get_height(bo),
                                fb_pixel_format_, handles, strides, offsets,
                                &framebuffer_, 0)) {
       PLOG(ERROR) << "Failed to register buffer";
@@ skipping 21 matching lines @@
 
 uint32_t GbmBufferBase::GetFramebufferPixelFormat() const {
   return fb_pixel_format_;
 }
 
 bool GbmBufferBase::RequiresGlFinish() const {
   return !drm_->is_primary_device();
 }
 
 }  // namespace ui