Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 1483543003: No need for SubtreeStyleChange for results attribute change. (Closed)

Created:
5 years ago by rune
Modified:
5 years ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

No need for SubtreeStyleChange for results attribute change. The results attribute change causes appearance changes when changing between negative and non-negative values. That is currently handled by a lazyReattachIfAttached. The following SubtreeStyleChange should not have an effect in that case. The reattach condition was changed to not include the change between different negative values. R=tkent@chromium.org BUG=557440 Committed: https://crrev.com/a1f820202cfb28e67a53fa5aa9df318ee85d72b3 Cr-Commit-Position: refs/heads/master@{#362077}

Patch Set 1 #

Patch Set 2 : Compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/forms/search/search-results-attribute.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/search/search-results-attribute-expected.html View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
rune
5 years ago (2015-11-27 15:18:01 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483543003/1
5 years ago (2015-11-27 15:18:06 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/62934) chromeos_daisy_chromium_compile_only_ng on ...
5 years ago (2015-11-27 15:28:39 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483543003/20001
5 years ago (2015-11-27 15:34:18 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-27 18:00:58 UTC) #9
tkent
lgtm. Though I'd like to remove the non-standard |results| attribute, reducing SubtreeStyleChange is great.
5 years ago (2015-11-29 23:44:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483543003/20001
5 years ago (2015-11-30 00:14:55 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-30 01:24:03 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-30 01:24:56 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a1f820202cfb28e67a53fa5aa9df318ee85d72b3
Cr-Commit-Position: refs/heads/master@{#362077}

Powered by Google App Engine
This is Rietveld 408576698