Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 1483543003: No need for SubtreeStyleChange for results attribute change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compile fix Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/search/search-results-attribute-expected.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 732 matching lines...) Expand 10 before | Expand all | Expand 10 after
743 } else if (name == usemapAttr || name == accesskeyAttr) { 743 } else if (name == usemapAttr || name == accesskeyAttr) {
744 // FIXME: ignore for the moment 744 // FIXME: ignore for the moment
745 } else if (name == onsearchAttr) { 745 } else if (name == onsearchAttr) {
746 // Search field and slider attributes all just cause updateFromElement t o be called through style recalcing. 746 // Search field and slider attributes all just cause updateFromElement t o be called through style recalcing.
747 setAttributeEventListener(EventTypeNames::search, createAttributeEventLi stener(this, name, value, eventParameterName())); 747 setAttributeEventListener(EventTypeNames::search, createAttributeEventLi stener(this, name, value, eventParameterName()));
748 } else if (name == resultsAttr) { 748 } else if (name == resultsAttr) {
749 int oldResults = m_maxResults; 749 int oldResults = m_maxResults;
750 m_maxResults = !value.isNull() ? std::min(value.toInt(), maxSavedResults ) : -1; 750 m_maxResults = !value.isNull() ? std::min(value.toInt(), maxSavedResults ) : -1;
751 // FIXME: Detaching just for maxResults change is not ideal. We should figure out the right 751 // FIXME: Detaching just for maxResults change is not ideal. We should figure out the right
752 // time to relayout for this change. 752 // time to relayout for this change.
753 if (m_maxResults != oldResults && (m_maxResults <= 0 || oldResults <= 0) ) 753 if ((m_maxResults < 0) != (oldResults < 0))
754 lazyReattachIfAttached(); 754 lazyReattachIfAttached();
755 setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::fro mAttribute(resultsAttr));
756 UseCounter::count(document(), UseCounter::ResultsAttribute); 755 UseCounter::count(document(), UseCounter::ResultsAttribute);
757 } else if (name == incrementalAttr) { 756 } else if (name == incrementalAttr) {
758 setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::fro mAttribute(incrementalAttr)); 757 setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::fro mAttribute(incrementalAttr));
759 UseCounter::count(document(), UseCounter::IncrementalAttribute); 758 UseCounter::count(document(), UseCounter::IncrementalAttribute);
760 } else if (name == minAttr) { 759 } else if (name == minAttr) {
761 m_inputTypeView->minOrMaxAttributeChanged(); 760 m_inputTypeView->minOrMaxAttributeChanged();
762 m_inputType->sanitizeValueInResponseToMinOrMaxAttributeChange(); 761 m_inputType->sanitizeValueInResponseToMinOrMaxAttributeChange();
763 setNeedsValidityCheck(); 762 setNeedsValidityCheck();
764 UseCounter::count(document(), UseCounter::MinAttribute); 763 UseCounter::count(document(), UseCounter::MinAttribute);
765 } else if (name == maxAttr) { 764 } else if (name == maxAttr) {
(...skipping 1185 matching lines...) Expand 10 before | Expand all | Expand 10 after
1951 void HTMLInputElement::ensurePrimaryContent() 1950 void HTMLInputElement::ensurePrimaryContent()
1952 { 1951 {
1953 m_inputTypeView->ensurePrimaryContent(); 1952 m_inputTypeView->ensurePrimaryContent();
1954 } 1953 }
1955 1954
1956 bool HTMLInputElement::hasFallbackContent() const 1955 bool HTMLInputElement::hasFallbackContent() const
1957 { 1956 {
1958 return m_inputTypeView->hasFallbackContent(); 1957 return m_inputTypeView->hasFallbackContent();
1959 } 1958 }
1960 } // namespace 1959 } // namespace
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/search/search-results-attribute-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698