Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1483433002: Revert of Only build against prebuilt sysroot when using clang (Closed)

Created:
5 years ago by brucedawson
Modified:
5 years ago
Reviewers:
Dirk Pranke, Sam Clegg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Only build against prebuilt sysroot when using clang (patchset #3 id:40001 of https://codereview.chromium.org/1476923005/ ) Reason for revert: Speculative revert to fix: FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -d google_chrome -c beta dpkg-shlibdeps: warning: binaries to analyze should already be installed in their package's directory. 4c4 < libc6 (>= 2.11) --- > libc6 (>= 2.15) https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/builds/43856/steps/compile/logs/stdio Original issue's description: > Only build against prebuilt sysroot when using clang > > Its is not currently possible to use gcc with the sysroot > since the sysroot only contains C++ headers for gcc 4.6 > and gcc 4.8 is required to build chromium. Luckily clang > is more flexible and able to detect and work with the 4.6 > headers in the sysroot. > > BUG=504446 > > Committed: https://crrev.com/ccc8c1e14c155255a8ef844704d97fa8e7d0dac2 > Cr-Commit-Position: refs/heads/master@{#361905} TBR=dpranke@chromium.org,sbc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504446 Committed: https://crrev.com/10c8cbc6c725a8aee45a539e0e5acefbd027e011 Cr-Commit-Position: refs/heads/master@{#361916}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M build/common.gypi View 5 chunks +6 lines, -9 lines 0 comments Download
M build/config/sysroot.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
brucedawson
Created Revert of Only build against prebuilt sysroot when using clang
5 years ago (2015-11-26 19:26:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483433002/1
5 years ago (2015-11-26 19:26:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 19:27:32 UTC) #4
commit-bot: I haz the power
5 years ago (2015-11-26 19:28:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10c8cbc6c725a8aee45a539e0e5acefbd027e011
Cr-Commit-Position: refs/heads/master@{#361916}

Powered by Google App Engine
This is Rietveld 408576698