Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1483403002:
Fix the crash problem on WebGL2 conformance test of negative state api. (Closed)
|
Created:
5 years ago by cyzero.kim Modified:
5 years ago CC:
chromium-reviews, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix the crash problem on WebGL2 conformance test of negative state api.
Add the checking for uniform block name size.
BUG=564000
Committed: https://crrev.com/b1d4e8745fb037122e8a3fae8953b57c3f782b6a
Cr-Commit-Position: refs/heads/master@{#363162}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove synthesize a GL error. And change Initialize length to zero. #Messages
Total messages: 17 (5 generated)
cyzero.kim@samsung.com changed reviewers: + kbr@chromium.org, piman@chromium.org, zmo@chromium.org
Please review this one.
https://codereview.chromium.org/1483403002/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp (right): https://codereview.chromium.org/1483403002/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:2218: synthesizeGLError(GL_INVALID_VALUE, "getActiveUniformBlockName", "invalid uniform block name string"); Is it necessary to synthesize a GL error? One should already have been generated. See https://www.opengl.org/sdk/docs/man3/xhtml/glGetActiveUniformBlockName.xml . "If an error occurs, nothing will be written to uniformBlockName or length." In this case perhaps the check should be "if (length < 0)".
https://codereview.chromium.org/1483403002/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp (right): https://codereview.chromium.org/1483403002/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:2215: GLsizei length = -1; Initialize length to 0 is enough, returning String(name.get(), 0) is the same as returning String(), I think.
On 2015/12/02 00:38:42, Ken Russell wrote: > https://codereview.chromium.org/1483403002/diff/1/third_party/WebKit/Source/m... > File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp > (right): > > https://codereview.chromium.org/1483403002/diff/1/third_party/WebKit/Source/m... > third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:2218: > synthesizeGLError(GL_INVALID_VALUE, "getActiveUniformBlockName", "invalid > uniform block name string"); > Is it necessary to synthesize a GL error? One should already have been > generated. See > https://www.opengl.org/sdk/docs/man3/xhtml/glGetActiveUniformBlockName.xml . "If > an error occurs, nothing will be written to uniformBlockName or length." In this > case perhaps the check should be "if (length < 0)". You are right. It is unnecessary gl error. Driver will return gl error.
On 2015/12/02 00:46:10, Zhenyao Mo wrote: > https://codereview.chromium.org/1483403002/diff/1/third_party/WebKit/Source/m... > File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp > (right): > > https://codereview.chromium.org/1483403002/diff/1/third_party/WebKit/Source/m... > third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:2215: > GLsizei length = -1; > Initialize length to 0 is enough, returning String(name.get(), 0) is the same as > returning String(), I think. Yes, It's better than before. Please take another look.
LGTM
LGTM too
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483403002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_android on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_android_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by cyzero.kim@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483403002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix the crash problem on WebGL2 conformance test of negative state api. Add the checking for uniform block name size. BUG=564000 ========== to ========== Fix the crash problem on WebGL2 conformance test of negative state api. Add the checking for uniform block name size. BUG=564000 Committed: https://crrev.com/b1d4e8745fb037122e8a3fae8953b57c3f782b6a Cr-Commit-Position: refs/heads/master@{#363162} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b1d4e8745fb037122e8a3fae8953b57c3f782b6a Cr-Commit-Position: refs/heads/master@{#363162} |
