Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

Issue 1483403002: Fix the crash problem on WebGL2 conformance test of negative state api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove synthesize a GL error. And change Initialize length to zero. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
index e8d9ee846d1ac3f0b0e95e7e5915a68a22b34ce5..948e7b3c2ffa3f907b9942f8a66587e0969f9768 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
@@ -2211,8 +2211,10 @@ String WebGL2RenderingContextBase::getActiveUniformBlockName(WebGLProgram* progr
return String();
}
OwnPtr<GLchar[]> name = adoptArrayPtr(new GLchar[maxNameLength]);
- GLsizei length;
+
+ GLsizei length = 0;
webContext()->getActiveUniformBlockName(objectOrZero(program), uniformBlockIndex, maxNameLength, &length, name.get());
+
return String(name.get(), length);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698