Source/core/dom/CustomElementRegistry.h - Issue 14834002: Set a bit on Custom Elements on creation to simplify wrapping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/CustomElementRegistry.h

Issue 14834002: Set a bit on Custom Elements on creation to simplify wrapping (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Now avoids hitting assert. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/CustomElementRegistry.h

diff --git a/Source/core/dom/CustomElementRegistry.h b/Source/core/dom/CustomElementRegistry.h

index 77ffd405f88c0815ae97808021f80e62a479c871..86869d94433fd287360eab00667df061bb7403c6 100644

--- a/Source/core/dom/CustomElementRegistry.h

+++ b/Source/core/dom/CustomElementRegistry.h

@@ -79,9 +79,6 @@ public:

PassRefPtr<CustomElementConstructor> registerElement(WebCore::ScriptState*, const AtomicString& name, const Dictionary& options, ExceptionCode&);

- // FIXME: findFor is dangerous since it consults the "is"

- // attribute; that should only be consulted at element creation

- // time.

PassRefPtr<CustomElementDefinition> findFor(Element*) const;

PassRefPtr<CustomElementDefinition> findAndCheckNamespace(const AtomicString& type, const AtomicString& namespaceURI) const;