Set a bit on Custom Elements on creation to simplify wrapping

Set a bit on Custom Elements on creation to simplify wrapping

For now, this makes wrapping faster because the wrapper factory can
check this bit instead of examining the tag name and "is" attribute.

This bit will soon be required for correctness: Currently, because
elements are only activated at creation time, there is no window in
which the "is" attribute can be changed by script before the element
is upgraded. Soon we will do post-hoc upgrade of custom elements
created before their definitions are available. This bit will be
necessary for opting elements into that processing.

Committed in r149589; rolled out in r149593. Now avoids hitting assert.

BUG=233775
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149626

[dominicc (has gone to gerrit), 2013-05-02 02:54:11]

This bit is the tiny acorn from which mighty oaks of upgraded elements will
grow. PTAL.

[esprehn, 2013-05-02 03:27:25]

There's plenty of bits in NodeFlags, lets use one of those for now. Allocating
an ElementRareData for every custom element is 160+ bytes of overhead plus the
malloc cost which doesn't make any sense when there's bits available.

[dglazkov, 2013-05-02 03:47:12]

glorious, except for:

https://codereview.chromium.org/14834002/diff/1/Source/core/dom/Element.cpp
File Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/14834002/diff/1/Source/core/dom/Element.cpp#n...
Source/core/dom/Element.cpp:1551: return hasRareData() &&
elementRareData()->isCustomElement();
I agree with Elliott, let's use bits.

[dominicc (has gone to gerrit), 2013-05-02 03:53:59]

Thanks for the quick turnaround. Now with less rare data. PTAL.

[esprehn, 2013-05-02 03:55:29]

On 2013/05/02 03:53:59, dominicc wrote:
> Thanks for the quick turnaround. Now with less rare data. PTAL.

LGTM.

[commit-bot: I haz the power, 2013-05-02 05:15:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominicc@chromium.org/14834002/6001

[commit-bot: I haz the power, 2013-05-02 05:15:45]

Failed to apply patch for Source/bindings/v8/CustomElementHelpers.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/v8/CustomElementHelpers.cpp
  Hunk #1 FAILED at 244.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/bindings/v8/CustomElementHelpers.cpp.rej

Patch:       Source/bindings/v8/CustomElementHelpers.cpp
Index: Source/bindings/v8/CustomElementHelpers.cpp
diff --git a/Source/bindings/v8/CustomElementHelpers.cpp
b/Source/bindings/v8/CustomElementHelpers.cpp
index
7ad874e5b5062e78c1d2d018001f17f0b3ce1f5e..886de9de965c1db42dc51a326c1fc9699b4a78ce
100644
--- a/Source/bindings/v8/CustomElementHelpers.cpp
+++ b/Source/bindings/v8/CustomElementHelpers.cpp
@@ -244,13 +244,6 @@ const QualifiedName*
CustomElementHelpers::findLocalName(v8::Handle<v8::Object>
     return 0;
 }
 
-bool CustomElementHelpers::isCustomElement(Element* element)
-{
-    // FIXME: This dynamically consults the "is" attribute; instead a
-    // bit should be marked on elements that are Custom Elements
-    return CustomElementRegistry::isCustomTagName(element->localName()) ||
CustomElementRegistry::isCustomTagName(element->getAttribute(HTMLNames::isAttr));
-}
-
 void CustomElementHelpers::invokeReadyCallbackIfNeeded(Element* element,
v8::Handle<v8::Context> context)
 {
     v8::Handle<v8::Value> wrapperValue = toV8(element, context->Global(),
context->GetIsolate());

[dominicc (has gone to gerrit), 2013-05-02 05:17:38]

It will be simplest if <https://codereview.chromium.org/14776002/> goes first.
That is waiting for haraken's seal of approval.

[haraken, 2013-05-02 05:18:46]

On 2013/05/02 05:17:38, dominicc wrote:
> It will be simplest if <https://codereview.chromium.org/14776002/> goes first.
> That is waiting for haraken's seal of approval.

Let me take a look in two hours.

[commit-bot: I haz the power, 2013-05-02 11:00:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominicc@chromium.org/14834002/6001

[commit-bot: I haz the power, 2013-05-02 11:48:30]

Change committed as 149589

[commit-bot: I haz the power, 2013-05-02 23:55:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominicc@chromium.org/14834002/20001

[commit-bot: I haz the power, 2013-05-03 00:51:42]

Change committed as 149626