Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1483373002: [crankshaft] Fix crash when case labels inline endless loops (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Fix crash when case labels inline endless loops The fix is to bail out of compilation in that case. BUG=chromium:551287 LOG=n R=yangguo@chromium.org Committed: https://crrev.com/3cb3a6fe4a5c0c655432001d0fb7771b2edfb559 Cr-Commit-Position: refs/heads/master@{#32454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M src/bailout-reason.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-551287.js View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
5 years ago (2015-12-01 11:35:37 UTC) #1
Yang
On 2015/12/01 11:35:37, Jakob wrote: lgtm.
5 years ago (2015-12-01 11:36:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483373002/1
5 years ago (2015-12-01 11:37:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 12:17:00 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-01 12:17:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cb3a6fe4a5c0c655432001d0fb7771b2edfb559
Cr-Commit-Position: refs/heads/master@{#32454}

Powered by Google App Engine
This is Rietveld 408576698