src/crankshaft/hydrogen.cc - Issue 1483373002: [crankshaft] Fix crash when case labels inline endless loops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen.cc

Issue 1483373002: [crankshaft] Fix crash when case labels inline endless loops (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/hydrogen.cc

diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc

index 249611e143722baf74fb6f8f39d08e98245c98a5..0ddd78815378c2d7535bd6983553ce557ae900c0 100644

--- a/src/crankshaft/hydrogen.cc

+++ b/src/crankshaft/hydrogen.cc

@@ -5044,7 +5044,8 @@ void HOptimizedGraphBuilder::VisitSwitchStatement(SwitchStatement* stmt) {

}

// Generate a compare and branch.

- CHECK_ALIVE(VisitForValue(clause->label()));

+ CHECK_BAILOUT(VisitForValue(clause->label()));

+ if (current_block() == NULL) return Bailout(kUnsupportedSwitchStatement);

HValue* label_value = Pop();

Type* label_type = clause->label()->bounds().lower;

« no previous file with comments | « src/bailout-reason.h ('k') | test/mjsunit/regress/regress-crbug-551287.js » ('j') | no next file with comments »