Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1483343002: [x86] Sane default for Label::Distance on JumpIfRoot/JumpIfNotRoot. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x86] Sane default for Label::Distance on JumpIfRoot/JumpIfNotRoot. R=jarin@chromium.org BUG=chromium:563929 LOG=n Committed: https://crrev.com/c83db2d071dc3f3493f5d10cf524bd2d8b91ac9b Cr-Commit-Position: refs/heads/master@{#32456}

Patch Set 1 #

Patch Set 2 : Moar oahsame regression test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M src/ia32/macro-assembler-ia32.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 2 chunks +4 lines, -4 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-563929.js View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Benedikt Meurer
5 years ago (2015-12-01 10:41:04 UTC) #1
Jarin
lgtm once the test is changed to something reasonable.
5 years ago (2015-12-01 11:10:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483343002/20001
5 years ago (2015-12-01 11:46:09 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-01 12:23:21 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-01 12:23:37 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c83db2d071dc3f3493f5d10cf524bd2d8b91ac9b
Cr-Commit-Position: refs/heads/master@{#32456}

Powered by Google App Engine
This is Rietveld 408576698