Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2145)

Unified Diff: src/x64/macro-assembler-x64.h

Issue 1483343002: [x86] Sane default for Label::Distance on JumpIfRoot/JumpIfNotRoot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Moar oahsame regression test. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ia32/macro-assembler-ia32.h ('k') | test/mjsunit/regress/regress-crbug-563929.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x64/macro-assembler-x64.h
diff --git a/src/x64/macro-assembler-x64.h b/src/x64/macro-assembler-x64.h
index dbf46782a4dff046b88c6a055cc54aad9fae6f07..1dd561bd061de10e5df926b0bd2b46ccb37b8a60 100644
--- a/src/x64/macro-assembler-x64.h
+++ b/src/x64/macro-assembler-x64.h
@@ -149,13 +149,13 @@ class MacroAssembler: public Assembler {
// Compare the object in a register to a value and jump if they are equal.
void JumpIfRoot(Register with, Heap::RootListIndex index, Label* if_equal,
- Label::Distance if_equal_distance = Label::kNear) {
+ Label::Distance if_equal_distance = Label::kFar) {
CompareRoot(with, index);
j(equal, if_equal, if_equal_distance);
}
void JumpIfRoot(const Operand& with, Heap::RootListIndex index,
Label* if_equal,
- Label::Distance if_equal_distance = Label::kNear) {
+ Label::Distance if_equal_distance = Label::kFar) {
CompareRoot(with, index);
j(equal, if_equal, if_equal_distance);
}
@@ -163,13 +163,13 @@ class MacroAssembler: public Assembler {
// Compare the object in a register to a value and jump if they are not equal.
void JumpIfNotRoot(Register with, Heap::RootListIndex index,
Label* if_not_equal,
- Label::Distance if_not_equal_distance = Label::kNear) {
+ Label::Distance if_not_equal_distance = Label::kFar) {
CompareRoot(with, index);
j(not_equal, if_not_equal, if_not_equal_distance);
}
void JumpIfNotRoot(const Operand& with, Heap::RootListIndex index,
Label* if_not_equal,
- Label::Distance if_not_equal_distance = Label::kNear) {
+ Label::Distance if_not_equal_distance = Label::kFar) {
CompareRoot(with, index);
j(not_equal, if_not_equal, if_not_equal_distance);
}
« no previous file with comments | « src/ia32/macro-assembler-ia32.h ('k') | test/mjsunit/regress/regress-crbug-563929.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698