Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1483233002: Merge to M48: Handle server profile/card disappearing while launching editor. (Closed)

Created:
5 years ago by please use gerrit instead
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Merge to M48: Handle server profile/card disappearing while launching editor. Sync can remove the server card or server profile while launching the card/profile editor. This patch checks whether the data is still available. If sync deleted the data, then the user sees the refreshed list of cards and profiles. Local profiles are not affected by this change. Editing a non-existent profile is how you can create a new local profile. Local cards are not affected by this change either. Editing a non-existent card is how you can create a new local card. Also, local cards are not synced. BUG=560467 Review URL: https://codereview.chromium.org/1483063003 Cr-Commit-Position: refs/heads/master@{#362255} (cherry picked from commit c6055bf304d5d81b649435ef8255be766f1c969f) Committed: https://chromium.googlesource.com/chromium/src/+/4126e65af5a188ee4ea2913944fc2df4fbfd36e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardPreferences.java View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerProfilePreferences.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
please use gerrit instead
5 years ago (2015-11-30 23:48:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4126e65af5a188ee4ea2913944fc2df4fbfd36e9.

Powered by Google App Engine
This is Rietveld 408576698