Handle server profile/card disappearing while launching editor.

Handle server profile/card disappearing while launching editor.

Sync can remove the server card or server profile while launching the
card/profile editor. This patch checks whether the data is still
available. If sync deleted the data, then the user sees the refreshed
list of cards and profiles.

Local profiles are not affected by this change. Editing a non-existent
profile is how you can create a new local profile.

Local cards are not affected by this change either. Editing a
non-existent card is how you can create a new local card. Also, local
cards are not synced.

BUG=560467
Committed: https://crrev.com/c6055bf304d5d81b649435ef8255be766f1c969f
Cr-Commit-Position: refs/heads/master@{#362255}

[please use gerrit instead, 2015-11-30 20:41:52]

rouslan@chromium.org changed reviewers:
+ newt@chromium.org

[please use gerrit instead, 2015-11-30 20:41:52]

newt@ PTAL

[newt (away), 2015-11-30 21:43:57]

lgtm after question

https://codereview.chromium.org/1483063003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardPreferences.java
(right):

https://codereview.chromium.org/1483063003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardPreferences.java:71:
PersonalDataManager.getInstance().clearUnmaskedCache(mGUID);
What happens on this line if mGUID no longer represents a valid card?

[please use gerrit instead, 2015-11-30 22:38:49]

Sending to cq.

https://codereview.chromium.org/1483063003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardPreferences.java
(right):

https://codereview.chromium.org/1483063003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardPreferences.java:71:
PersonalDataManager.getInstance().clearUnmaskedCache(mGUID);
On 2015/11/30 21:43:57, newt wrote:
> What happens on this line if mGUID no longer represents a valid card?

The invalid GUID is skipped over:

https://code.google.com/p/chromium/codesearch#chromium/src/components/autofil...

[please use gerrit instead, 2015-11-30 22:38:56]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2015-11-30 22:40:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1483063003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1483063003/1

[commit-bot: I haz the power, 2015-11-30 22:58:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-30 22:59:40]

Description was changed from

==========
Handle server profile/card disappearing while launching editor.

Sync can remove the server card or server profile while launching the
card/profile editor. This patch checks whether the data is still
available. If sync deleted the data, then the user sees the refreshed
list of cards and profiles.

Local profiles are not affected by this change. Editing a non-existent
profile is how you can create a new local profile.

Local cards are not affected by this change either. Editing a
non-existent card is how you can create a new local card. Also, local
cards are not synced.

BUG=560467
==========

to

==========
Handle server profile/card disappearing while launching editor.

Sync can remove the server card or server profile while launching the
card/profile editor. This patch checks whether the data is still
available. If sync deleted the data, then the user sees the refreshed
list of cards and profiles.

Local profiles are not affected by this change. Editing a non-existent
profile is how you can create a new local profile.

Local cards are not affected by this change either. Editing a
non-existent card is how you can create a new local card. Also, local
cards are not synced.

BUG=560467

Committed: https://crrev.com/c6055bf304d5d81b649435ef8255be766f1c969f
Cr-Commit-Position: refs/heads/master@{#362255}
==========

[commit-bot: I haz the power, 2015-11-30 22:59:41]

Patchset 1 (id:??) landed as
https://crrev.com/c6055bf304d5d81b649435ef8255be766f1c969f
Cr-Commit-Position: refs/heads/master@{#362255}