Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1483143002: Modify iOSShell-gyp to generate unique bundle identifier (Closed)

Created:
5 years ago by stephana
Modified:
5 years ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Modify iOSShell-gyp to generate unique bundle identifier BUG=skia: Committed: https://skia.googlesource.com/skia/+/c60b310af7635204b8186c616ffdd190d8bf5fe1

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M experimental/iOSShell/iOSShell-Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M gyp/iOSShell.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M platform_tools/ios/bin/ios_setup.sh View 1 2 3 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
stephana
5 years ago (2015-12-02 16:38:30 UTC) #3
borenet
LGTM
5 years ago (2015-12-02 17:32:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483143002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483143002/60001
5 years ago (2015-12-02 17:32:49 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-02 17:45:36 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c60b310af7635204b8186c616ffdd190d8bf5fe1

Powered by Google App Engine
This is Rietveld 408576698