Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: platform_tools/ios/bin/ios_setup.sh

Issue 1483143002: Modify iOSShell-gyp to generate unique bundle identifier (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/iOSShell.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/ios/bin/ios_setup.sh
diff --git a/platform_tools/ios/bin/ios_setup.sh b/platform_tools/ios/bin/ios_setup.sh
index 53a33c67bb1d7b6f229e47aaabe8f11472ff4df3..dbfed7c26fea8541c1e80b74d207ef8a0ddf3e84 100755
--- a/platform_tools/ios/bin/ios_setup.sh
+++ b/platform_tools/ios/bin/ios_setup.sh
@@ -18,9 +18,6 @@ IOS_DOCS_DIR="Documents"
# Temporary location to assemble the app into an .ipa package.
IOS_PCKG_DIR="/tmp/ios_pckg"
-# Bundle id of the app that runs the tests.
-TEST_RUNNER_BUNDLE_ID="com.google.iOSShell"
-
# Directory with the Skia source.
SKIA_SRC_DIR=$(cd "${SCRIPT_DIR}/../../.."; pwd)
@@ -30,7 +27,7 @@ PROVISIONING_PROFILE=""
# Code Signing identity - this needs to be set up on the local machine.
CODE_SIGN_IDENTITY="iPhone Developer"
-IOS_BUNDLE_ID="com.google.iOSShell"
+IOS_BUNDLE_ID="com.google.iOSShell.`hostname | md5`"
IOS_RESULTS_DIR="results"
@@ -94,7 +91,7 @@ ios_mount() {
if [[ ! -d "$IOS_MOUNT_POINT" ]]; then
mkdir -p $IOS_MOUNT_POINT
fi
- ifuse --container $TEST_RUNNER_BUNDLE_ID $IOS_MOUNT_POINT
+ ifuse --container $IOS_BUNDLE_ID $IOS_MOUNT_POINT
sleep 1
>&2 echo "Successfully mounted device."
}
« no previous file with comments | « gyp/iOSShell.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698