Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 1483103002: [Cronet] Add QUIC experimental params (Closed)

Created:
5 years ago by xunjieli
Modified:
5 years ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

[Cronet] Add QUIC experimental params This CL plumbs four QUIC experimental params ( quic_store_server_configs_in_properties, quic_delay_tcp_race, quic_max_number_of_lossy_connections, quic_packet_loss_threshold) from Cronet's setExperimentalOptions API to net::HttpNetworkSession. This CL also adds a unittests target to run the unittests. A followup CL will enable the unittests on the cronet bots. BUG=545118 NOTRY=true NOPRESUBMIT=true Committed: https://crrev.com/fde0b72c603cd111c36ca4cc416d82a7395bcf6c Cr-Commit-Position: refs/heads/master@{#360454} Committed: https://crrev.com/8ece3aa6845350c1971a3e824bf148f3e8de3253 Cr-Commit-Position: refs/heads/master@{#360875} Review URL: https://codereview.chromium.org/1448583003 Cr-Commit-Position: refs/heads/master@{#361138} (cherry picked from commit f24ee5f5afeb59d2a9134a7b986efb6483629fe5)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -13 lines) Patch
M components/components_tests.gyp View 3 chunks +0 lines, -5 lines 0 comments Download
M components/cronet.gypi View 5 chunks +32 lines, -2 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java View 1 chunk +6 lines, -2 lines 0 comments Download
A + components/cronet/run_all_unittests.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/cronet/url_request_context_config.cc View 3 chunks +33 lines, -0 lines 0 comments Download
A components/cronet/url_request_context_config_unittest.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 2 chunks +25 lines, -0 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
xunjieli
PTAL
5 years ago (2015-11-30 18:26:34 UTC) #2
mef
lgtm
5 years ago (2015-11-30 19:01:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483103002/1
5 years ago (2015-11-30 19:08:56 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-30 19:14:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698