Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1448583003: [Cronet] Add QUIC experimental params (Closed)

Created:
5 years, 1 month ago by xunjieli
Modified:
5 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, pauljensen
Base URL:
https://chromium.googlesource.com/chromium/src.git@experiment_ops
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Add QUIC experimental params This CL plumbs four QUIC experimental params ( quic_store_server_configs_in_properties, quic_delay_tcp_race, quic_max_number_of_lossy_connections, quic_packet_loss_threshold) from Cronet's setExperimentalOptions API to net::HttpNetworkSession. This CL also adds a unittests target to run the unittests. A followup CL will enable the unittests on the cronet bots. BUG=545118 Committed: https://crrev.com/fde0b72c603cd111c36ca4cc416d82a7395bcf6c Cr-Commit-Position: refs/heads/master@{#360454} Committed: https://crrev.com/8ece3aa6845350c1971a3e824bf148f3e8de3253 Cr-Commit-Position: refs/heads/master@{#360875} Committed: https://crrev.com/f24ee5f5afeb59d2a9134a7b986efb6483629fe5 Cr-Commit-Position: refs/heads/master@{#361138}

Patch Set 1 #

Patch Set 2 : Add test and quic_delay_tcp_race #

Patch Set 3 : Rebased #

Patch Set 4 : Self review #

Patch Set 5 : #

Total comments: 8

Patch Set 6 : Add two more params and address comments #

Total comments: 4

Patch Set 7 : Address comments #

Patch Set 8 : Initialize variables #

Patch Set 9 : Rebased #

Patch Set 10 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -13 lines) Patch
M components/components_tests.gyp View 1 2 3 4 5 6 7 8 9 3 chunks +0 lines, -5 lines 0 comments Download
M components/cronet.gypi View 1 2 3 4 5 6 7 8 9 5 chunks +32 lines, -2 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java View 1 2 3 4 5 1 chunk +6 lines, -2 lines 0 comments Download
A + components/cronet/run_all_unittests.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M components/cronet/url_request_context_config.cc View 1 2 3 4 5 6 3 chunks +33 lines, -0 lines 0 comments Download
A components/cronet/url_request_context_config_unittest.cc View 1 2 3 4 5 6 1 chunk +62 lines, -0 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 1 2 3 4 5 6 7 8 2 chunks +25 lines, -0 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 2 3 4 5 6 7 8 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 56 (21 generated)
xunjieli
Raman, you mentioned that there are two QUIC parameters that you'd like to add, what ...
5 years, 1 month ago (2015-11-13 22:38:25 UTC) #3
ramant (doing other things)
lgtm LGTM. Would be awesome if we could write an unittest.
5 years, 1 month ago (2015-11-14 00:43:35 UTC) #5
xunjieli
On 2015/11/14 00:43:35, ramant wrote: > lgtm > > LGTM. Would be awesome if we ...
5 years, 1 month ago (2015-11-18 20:09:04 UTC) #9
ramant (doing other things)
On 2015/11/18 20:09:04, xunjieli wrote: > On 2015/11/14 00:43:35, ramant wrote: > > lgtm > ...
5 years, 1 month ago (2015-11-18 20:16:58 UTC) #10
ramant (doing other things)
Patch Set 5: LGTM https://codereview.chromium.org/1448583003/diff/100001/components/cronet/url_request_context_config_unittest.cc File components/cronet/url_request_context_config_unittest.cc (right): https://codereview.chromium.org/1448583003/diff/100001/components/cronet/url_request_context_config_unittest.cc#newcode36 components/cronet/url_request_context_config_unittest.cc:36: // Set a ProxyConfigService to ...
5 years, 1 month ago (2015-11-18 20:22:08 UTC) #11
mef
It would be nice to add more edge tests, but that should probably wait for ...
5 years, 1 month ago (2015-11-18 20:33:25 UTC) #12
xunjieli
Thanks! I have addressed comments and added two additional params. https://codereview.chromium.org/1448583003/diff/100001/components/cronet.gypi File components/cronet.gypi (right): https://codereview.chromium.org/1448583003/diff/100001/components/cronet.gypi#newcode449 ...
5 years, 1 month ago (2015-11-18 20:58:44 UTC) #13
ramant (doing other things)
Patch Set 6: LGTM https://codereview.chromium.org/1448583003/diff/120001/components/cronet/url_request_context_config.cc File components/cronet/url_request_context_config.cc (right): https://codereview.chromium.org/1448583003/diff/120001/components/cronet/url_request_context_config.cc#newcode50 components/cronet/url_request_context_config.cc:50: VLOG(1) << "Experimental Options:" << ...
5 years, 1 month ago (2015-11-18 21:22:09 UTC) #14
mef
https://codereview.chromium.org/1448583003/diff/100001/components/cronet.gypi File components/cronet.gypi (right): https://codereview.chromium.org/1448583003/diff/100001/components/cronet.gypi#newcode449 components/cronet.gypi:449: 'target_name': 'cronet_unittests', On 2015/11/18 20:58:44, xunjieli wrote: > On ...
5 years, 1 month ago (2015-11-18 21:35:34 UTC) #15
xunjieli
Thanks! PTAL https://codereview.chromium.org/1448583003/diff/100001/components/cronet.gypi File components/cronet.gypi (right): https://codereview.chromium.org/1448583003/diff/100001/components/cronet.gypi#newcode449 components/cronet.gypi:449: 'target_name': 'cronet_unittests', On 2015/11/18 21:35:33, mef wrote: ...
5 years, 1 month ago (2015-11-18 21:52:55 UTC) #16
mef
lgtm
5 years, 1 month ago (2015-11-18 22:07:19 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448583003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448583003/140001
5 years, 1 month ago (2015-11-18 22:28:37 UTC) #22
commit-bot: I haz the power
Committed patchset #7 (id:140001)
5 years, 1 month ago (2015-11-19 00:38:18 UTC) #23
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/fde0b72c603cd111c36ca4cc416d82a7395bcf6c Cr-Commit-Position: refs/heads/master@{#360454}
5 years, 1 month ago (2015-11-19 00:39:12 UTC) #24
Derek Bruening
I believe that this is the culprit for this uninitialized read: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/11562/steps/browser_tests/logs/ExtensionPreferenceApiTest.DataReductionProxy
5 years, 1 month ago (2015-11-19 02:58:49 UTC) #25
Derek Bruening
On 2015/11/19 02:58:49, Derek Bruening wrote: > I believe that this is the culprit for ...
5 years, 1 month ago (2015-11-19 03:03:34 UTC) #26
Derek Bruening
Plus errors on the Valgrind bots: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%284%29/builds/46086/steps/memory%20test%3A%20unit/logs/0E36676A13F00C97 UninitCondition Conditional jump or move depends on uninitialised ...
5 years, 1 month ago (2015-11-19 03:04:55 UTC) #27
Derek Bruening
A revert of this CL (patchset #7 id:140001) has been created in https://codereview.chromium.org/1454333002/ by bruening@chromium.org. ...
5 years, 1 month ago (2015-11-19 03:08:25 UTC) #28
xunjieli
Raman, could you take a look to see if the initial values are correct?
5 years, 1 month ago (2015-11-20 14:31:29 UTC) #30
ramant (doing other things)
Patch Set 8 LGTM (initial values are correct).
5 years, 1 month ago (2015-11-20 17:46:18 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448583003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448583003/160001
5 years, 1 month ago (2015-11-20 17:46:48 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/126071) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-11-20 17:48:33 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448583003/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448583003/180001
5 years, 1 month ago (2015-11-20 18:00:57 UTC) #39
commit-bot: I haz the power
Committed patchset #9 (id:180001)
5 years, 1 month ago (2015-11-20 19:22:44 UTC) #40
commit-bot: I haz the power
Patchset 9 (id:??) landed as https://crrev.com/8ece3aa6845350c1971a3e824bf148f3e8de3253 Cr-Commit-Position: refs/heads/master@{#360875}
5 years, 1 month ago (2015-11-20 19:23:40 UTC) #41
xunjieli
A revert of this CL (patchset #9 id:180001) has been created in https://codereview.chromium.org/1464903002/ by xunjieli@chromium.org. ...
5 years, 1 month ago (2015-11-20 19:44:11 UTC) #42
xunjieli
Hi Misha, could you take a look at the gyp file changes? The failure output ...
5 years, 1 month ago (2015-11-20 20:34:56 UTC) #43
xunjieli
On 2015/11/20 20:34:56, xunjieli wrote: > Hi Misha, could you take a look at the ...
5 years, 1 month ago (2015-11-20 20:35:54 UTC) #45
xunjieli
Hi Misha, the CL got reverted because it broke an internal bot. PTAL at new ...
5 years, 1 month ago (2015-11-23 16:20:11 UTC) #48
mef
On 2015/11/23 16:20:11, xunjieli wrote: > Hi Misha, the CL got reverted because it broke ...
5 years, 1 month ago (2015-11-23 16:27:22 UTC) #49
xunjieli
On 2015/11/23 16:27:22, mef wrote: > On 2015/11/23 16:20:11, xunjieli wrote: > > Hi Misha, ...
5 years, 1 month ago (2015-11-23 16:33:16 UTC) #50
mef
lgtm
5 years, 1 month ago (2015-11-23 16:43:45 UTC) #51
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448583003/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448583003/240001
5 years, 1 month ago (2015-11-23 16:46:34 UTC) #54
commit-bot: I haz the power
Committed patchset #10 (id:240001)
5 years, 1 month ago (2015-11-23 18:05:35 UTC) #55
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 18:06:25 UTC) #56
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/f24ee5f5afeb59d2a9134a7b986efb6483629fe5
Cr-Commit-Position: refs/heads/master@{#361138}

Powered by Google App Engine
This is Rietveld 408576698