Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 14830005: Remove the extension dialog extra border. (Closed)

Created:
7 years, 7 months ago by msw
Modified:
7 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, tfarina, chromium-apps-reviews_chromium.org, James Cook, rkc
Visibility:
Public.

Description

Remove the extension dialog extra border. ExtensionDialog uses Widget::CreateWindowWithParent. Use DialogDelegate::CreateDialogWidget instead. Does not change the old-style appearance or behavior. See before/after pics at http://crbug.com/166075#c63 Trigger the only user (select file dialog extension) in CrOS with CTRL+O. Also, remove the unused fullscreen dialog codepath. (Rahul said this is no longer used and may be removed) BUG=166075 TEST=new-style select file extension dialog does not have an extra border. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199646

Patch Set 1 #

Patch Set 2 : Remove unused fullscreen dialog codepath. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -93 lines) Patch
M chrome/browser/ui/views/extensions/extension_dialog.h View 1 6 chunks +4 lines, -23 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_dialog.cc View 1 4 chunks +9 lines, -70 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
msw
Hey Scott, please take a look; thanks!
7 years, 7 months ago (2013-05-10 21:37:39 UTC) #1
sky
LGTM
7 years, 7 months ago (2013-05-10 23:13:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/14830005/2001
7 years, 7 months ago (2013-05-10 23:18:18 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=147192
7 years, 7 months ago (2013-05-11 07:29:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/14830005/2001
7 years, 7 months ago (2013-05-11 18:03:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/14830005/2001
7 years, 7 months ago (2013-05-12 22:28:11 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-13 04:01:03 UTC) #7
Message was sent while issue was closed.
Change committed as 199646

Powered by Google App Engine
This is Rietveld 408576698