Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 148283017: Make GMs aware of what tool they're being run in. (Closed)

Created:
6 years, 10 months ago by bsalomon
Modified:
6 years, 10 months ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make GMs aware of what tool they're being run in. Add a saveLayer set of draws to convex_poly_clip and fix GPU bug where polygon clips don't account for the translation between clip and device space. BUG=skia:2051 Committed: http://code.google.com/p/skia/source/detail?r=13371

Patch Set 1 #

Total comments: 2

Patch Set 2 : w to this->getMode() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -53 lines) Patch
M bench/benchmain.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/convexpolyclip.cpp View 1 3 chunks +83 lines, -41 lines 0 comments Download
M gm/gm.h View 3 chunks +14 lines, -4 lines 0 comments Download
M gm/gm.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +8 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bsalomon
Rob for the GPU changes, Mike for the skiagm::GM::Mode stuff.
6 years, 10 months ago (2014-02-07 15:49:15 UTC) #1
robertphillips
lgtm + question. https://codereview.chromium.org/148283017/diff/1/gm/convexpolyclip.cpp File gm/convexpolyclip.cpp (right): https://codereview.chromium.org/148283017/diff/1/gm/convexpolyclip.cpp#newcode87 gm/convexpolyclip.cpp:87: int w = 435; w -> ...
6 years, 10 months ago (2014-02-07 15:58:47 UTC) #2
bsalomon
https://codereview.chromium.org/148283017/diff/1/gm/convexpolyclip.cpp File gm/convexpolyclip.cpp (right): https://codereview.chromium.org/148283017/diff/1/gm/convexpolyclip.cpp#newcode87 gm/convexpolyclip.cpp:87: int w = 435; On 2014/02/07 15:58:47, robertphillips wrote: ...
6 years, 10 months ago (2014-02-07 20:56:54 UTC) #3
bsalomon
I'm going to interpret Mike's silence as acquiescence. :)
6 years, 10 months ago (2014-02-07 20:57:42 UTC) #4
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 10 months ago (2014-02-07 20:57:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/148283017/1
6 years, 10 months ago (2014-02-07 20:57:59 UTC) #6
bsalomon
The CQ bit was unchecked by bsalomon@google.com
6 years, 10 months ago (2014-02-07 20:58:41 UTC) #7
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 10 months ago (2014-02-07 20:59:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/148283017/130001
6 years, 10 months ago (2014-02-07 20:59:36 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-07 21:13:16 UTC) #10
Message was sent while issue was closed.
Change committed as 13371

Powered by Google App Engine
This is Rietveld 408576698