Certificate Transparency: Enhance the CT log flag for multiple logs

chrome/common/chrome_switches.cc

Index: chrome/common/chrome_switches.cc
diff --git a/chrome/common/chrome_switches.cc b/chrome/common/chrome_switches.cc
index d16f161035c89e994e8cc14a7b426aac8fc59ef9..4daa41973378de10caa5b1952d448f55e6716413 100644
--- a/chrome/common/chrome_switches.cc
+++ b/chrome/common/chrome_switches.cc
@@ -143,14 +143,16 @@ const char kAutomationReinitializeOnChannelError[] =
 // will not occur in subsequent runs either.
 const char kCancelFirstRun[]                = "cancel-first-run";
 
-// Certificate Transparency: Uses the provided log for checking Signed
+// Certificate Transparency: Uses the provided log(s) for checking Signed
 // Certificate Timestamps provided with certificates.
 // The switch's value is:
-//   log_description:log_key
-// where:
-//   log_description is a textual description of the log
+//   log_description:log_key;log_description:log_key;...

[Lei Zhang, 2014/01/27 19:46:06]

Does |log_description| usually contain spaces? If so, then it's fine as is, as
shell users will have to wrap it in quotes anyway. Otherwise, perhaps a comma
would be a better delimiter, as shells already use semicolons to indicate the
end of a command.

[Eran M. (Google), 2014/01/28 09:13:02]

Done - switched to a comma. |log_description| can contain spaces in general but
as I expect this feature will mostly be used to test new CT logs, the names
specified here will not be final and not likely to contain spaces, so used a
comma to avoid forcing escaping the value of this switch.

+// where
+//   log_description is a textual description of the log.
 //   log_key is a Base64'd DER-encoded SubjectPublicKeyInfo of the log's
 //   public key.
+// Multiple logs can be specified by repeating description:key pairs,
+// separated by semicolon.
 const char kCertificateTransparencyLog[] =
     "certificate-transparency-log";