Certificate Transparency: Enhance the CT log flag for multiple logs

chrome/common/chrome_switches.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_switches.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 
 namespace switches {
@@ skipping 125 matching lines @@
 
 // Causes the automation provider to reinitialize its IPC channel instead of
 // shutting down when a client disconnects.
 const char kAutomationReinitializeOnChannelError[] =
     "automation-reinitialize-on-channel-error";
 
 // Similar to kNoFirstRun, but also drops the First Run beacon so that first run
 // will not occur in subsequent runs either.
 const char kCancelFirstRun[]                = "cancel-first-run";
 
-// Certificate Transparency: Uses the provided log for checking Signed
+// Certificate Transparency: Uses the provided log(s) for checking Signed
 // Certificate Timestamps provided with certificates.
 // The switch's value is:
-//   log_description:log_key
-// where:
-//   log_description is a textual description of the log
+//   log_description:log_key;log_description:log_key;...

[Lei Zhang, 2014/01/27 19:46:06]

Does |log_description| usually contain spaces? If so, then it's fine as is, as
shell users will have to wrap it in quotes anyway. Otherwise, perhaps a comma
would be a better delimiter, as shells already use semicolons to indicate the
end of a command.

[Eran M. (Google), 2014/01/28 09:13:02]

Done - switched to a comma. |log_description| can contain spaces in general but
as I expect this feature will mostly be used to test new CT logs, the names
specified here will not be final and not likely to contain spaces, so used a
comma to avoid forcing escaping the value of this switch.

+// where
+//   log_description is a textual description of the log.
 //   log_key is a Base64'd DER-encoded SubjectPublicKeyInfo of the log's
 //   public key.
+// Multiple logs can be specified by repeating description:key pairs,
+// separated by semicolon.
 const char kCertificateTransparencyLog[] =
     "certificate-transparency-log";
 
 // How often (in seconds) to check for updates. Should only be used for testing
 // purposes.
 const char kCheckForUpdateIntervalSec[]     = "check-for-update-interval";
 
 // Checks the cloud print connector policy, informing the service process if
 // the policy is set to disallow the connector, then quits.
 const char kCheckCloudPrintConnectorPolicy[] =
@@ skipping 1526 matching lines @@
 
 // -----------------------------------------------------------------------------
 // DO NOT ADD YOUR CRAP TO THE BOTTOM OF THIS FILE.
 //
 // You were going to just dump your switches here, weren't you? Instead, please
 // put them in alphabetical order above, or in order inside the appropriate
 // ifdef at the bottom. The order should match the header.
 // -----------------------------------------------------------------------------
 
 }  // namespace switches