Certificate Transparency: Enhance the CT log flag for multiple logs

Certificate Transparency: Enhance the CT log flag for multiple logs

Allow specifying multiple CT logs through the command line. This is
necessary in order to allow testing of multiple new logs at the same
time.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247685

[Eran M. (Google), 2014-01-27 12:59:28]

Lei,

Please take a look at this small flag parsing change.

It has been manually tested (I've verified I can add multiple logs by using
semicolon as separator)

[Lei Zhang, 2014-01-27 19:46:06]

https://codereview.chromium.org/148283002/diff/50001/chrome/browser/io_thread.cc
File chrome/browser/io_thread.cc (right):

https://codereview.chromium.org/148283002/diff/50001/chrome/browser/io_thread...
chrome/browser/io_thread.cc:565: size_t log_delim_pos = switch_value.find(";");
Would it be slightly easier / readable to do this parsing with
base::SplitString() and then iterating over the output vector?

https://codereview.chromium.org/148283002/diff/50001/chrome/common/chrome_swi...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/148283002/diff/50001/chrome/common/chrome_swi...
chrome/common/chrome_switches.cc:149: //  
log_description:log_key;log_description:log_key;...
Does |log_description| usually contain spaces? If so, then it's fine as is, as
shell users will have to wrap it in quotes anyway. Otherwise, perhaps a comma
would be a better delimiter, as shells already use semicolons to indicate the
end of a command.

[Eran M. (Google), 2014-01-28 09:13:02]

Thanks for the quick review, addressed all comments.

https://codereview.chromium.org/148283002/diff/50001/chrome/browser/io_thread.cc
File chrome/browser/io_thread.cc (right):

https://codereview.chromium.org/148283002/diff/50001/chrome/browser/io_thread...
chrome/browser/io_thread.cc:565: size_t log_delim_pos = switch_value.find(";");
On 2014/01/27 19:46:06, Lei Zhang wrote:
> Would it be slightly easier / readable to do this parsing with
> base::SplitString() and then iterating over the output vector?

Done.

https://codereview.chromium.org/148283002/diff/50001/chrome/common/chrome_swi...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/148283002/diff/50001/chrome/common/chrome_swi...
chrome/common/chrome_switches.cc:149: //  
log_description:log_key;log_description:log_key;...
On 2014/01/27 19:46:06, Lei Zhang wrote:
> Does |log_description| usually contain spaces? If so, then it's fine as is, as
> shell users will have to wrap it in quotes anyway. Otherwise, perhaps a comma
> would be a better delimiter, as shells already use semicolons to indicate the
> end of a command.

Done - switched to a comma. |log_description| can contain spaces in general but
as I expect this feature will mostly be used to test new CT logs, the names
specified here will not be final and not likely to contain spaces, so used a
comma to avoid forcing escaping the value of this switch.

[Lei Zhang, 2014-01-28 19:18:50]

lgtm

https://codereview.chromium.org/148283002/diff/40002/chrome/browser/io_thread.cc
File chrome/browser/io_thread.cc (right):

https://codereview.chromium.org/148283002/diff/40002/chrome/browser/io_thread...
chrome/browser/io_thread.cc:569: std::string curr_log = *it;
const ref instead?

[Eran M. (Google), 2014-01-29 09:40:46]

https://codereview.chromium.org/148283002/diff/40002/chrome/browser/io_thread.cc
File chrome/browser/io_thread.cc (right):

https://codereview.chromium.org/148283002/diff/40002/chrome/browser/io_thread...
chrome/browser/io_thread.cc:569: std::string curr_log = *it;
On 2014/01/28 19:18:50, Lei Zhang wrote:
> const ref instead?

Done.

[commit-bot: I haz the power, 2014-01-29 10:42:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eranm@google.com/148283002/90001

[commit-bot: I haz the power, 2014-01-29 11:16:19]

Retried try job too often on mac_rel for step(s) remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-01-29 12:37:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eranm@google.com/148283002/90001

[commit-bot: I haz the power, 2014-01-29 14:05:06]

Change committed as 247685