Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: src/a64/code-stubs-a64.h

Issue 148273008: SaveCallerSaveRegsisters needs to save all caller-save registers (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: updates Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/a64/code-stubs-a64.h
diff --git a/src/a64/code-stubs-a64.h b/src/a64/code-stubs-a64.h
index 4094887aaf69b03f9a68b06b406fe277f6634c2f..e63451d37c7326963a4153505afc8ab5ecd7fb8c 100644
--- a/src/a64/code-stubs-a64.h
+++ b/src/a64/code-stubs-a64.h
@@ -314,13 +314,11 @@ class RecordWriteStub: public PlatformCodeStub {
scratch1_ = Register(pool_available.PopLowestIndex());
scratch2_ = Register(pool_available.PopLowestIndex());
- // SaveCallerRegisters method needs to save caller saved register, however
- // we dont bother saving x8, x9, ip0 and ip1 because they are used as
- // scratch registers by the MacroAssembler.
+ // SaveCallerRegisters method needs to save caller saved register, howeve
Rodolph Perfetta (ARM) 2014/01/28 13:24:58 nit: however
+ // we dont bother saving ip0 and ip1 because they are used as scratch
+ // registers by the MacroAssembler.
saved_regs_.Remove(ip0);
saved_regs_.Remove(ip1);
- saved_regs_.Remove(x8);
- saved_regs_.Remove(x9);
// The scratch registers will be restored by other means so we don't need
// to save them with the other caller saved registers.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698