Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1482643002: Exclude some extension apis for Aura Android (Closed)

Created:
5 years ago by bshe
Modified:
5 years ago
Reviewers:
Finnur, mfomitchev
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Hadi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude some extension apis for Aura Android Extension is not supported for Aura Android yet. So exclude some of them to avoid pull unnecessary dependancy. BUG=548797 Committed: https://crrev.com/72e623ac3ef6cdc9d2323361eebe6f6a320a4b93 Cr-Commit-Position: refs/heads/master@{#362978}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -21 lines) Patch
M chrome/browser/extensions/BUILD.gn View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/browser_context_keyed_service_factories.cc View 4 chunks +9 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 4 chunks +23 lines, -16 lines 0 comments Download
M chrome/common/extensions/api/schemas.gni View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 1 4 chunks +12 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (12 generated)
bshe
Hi Finnur. Do you mind take a look at this CL? It basically disables a ...
5 years ago (2015-11-27 17:07:56 UTC) #2
mfomitchev
https://codereview.chromium.org/1482643002/diff/20001/chrome/browser/extensions/BUILD.gn File chrome/browser/extensions/BUILD.gn (right): https://codereview.chromium.org/1482643002/diff/20001/chrome/browser/extensions/BUILD.gn#newcode217 chrome/browser/extensions/BUILD.gn:217: sources -= [ Might be worth creating chrome_browser_extensions_non_android_sources for ...
5 years ago (2015-11-30 16:17:09 UTC) #4
bshe
PTAL. Thanks! https://codereview.chromium.org/1482643002/diff/20001/chrome/browser/extensions/BUILD.gn File chrome/browser/extensions/BUILD.gn (right): https://codereview.chromium.org/1482643002/diff/20001/chrome/browser/extensions/BUILD.gn#newcode217 chrome/browser/extensions/BUILD.gn:217: sources -= [ On 2015/11/30 16:17:09, mfomitchev ...
5 years ago (2015-11-30 17:00:54 UTC) #5
Finnur
LGTM (was traveling on Friday to MTV)
5 years ago (2015-11-30 17:31:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482643002/40001
5 years ago (2015-11-30 18:08:40 UTC) #11
bshe
On 2015/11/30 18:08:40, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years ago (2015-12-02 18:47:10 UTC) #13
mfomitchev
On 2015/12/02 18:47:10, bshe wrote: > On 2015/11/30 18:08:40, commit-bot: I haz the power wrote: ...
5 years ago (2015-12-02 19:50:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482643002/40001
5 years ago (2015-12-02 19:52:59 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/149042)
5 years ago (2015-12-02 20:43:33 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482643002/40001
5 years ago (2015-12-03 14:12:59 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-03 14:21:38 UTC) #22
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/72e623ac3ef6cdc9d2323361eebe6f6a320a4b93 Cr-Commit-Position: refs/heads/master@{#362978}
5 years ago (2015-12-03 14:22:46 UTC) #24
bshe
4 years, 11 months ago (2016-01-05 19:12:01 UTC) #25
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1558263002/ by bshe@chromium.org.

The reason for reverting is: We dont need to support Aura Android at current
stage. Revert related code..

Powered by Google App Engine
This is Rietveld 408576698