Issue 148263012: A64: Rejig truncating and non double to i/smi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148263012: A64: Rejig truncating and non double to i/smi (Closed)

Created:
6 years, 10 months ago by m.m.capewell

Modified:
6 years, 10 months ago

Reviewers:
baptiste.afsa1, Rodolph Perfetta (ARM)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/a64

Visibility:
Public.

More Reviews

Description

A64: Rejig truncating and non double to i/smi Replace existing DoubleToI/DoubleToSmi instructions with truncating and non- truncating versions. This allows reuse of common code, register constraints and environment requirements. Also, use new JumpIfMinusZero function in DoNumberUntagD to remove unimplemented code tag. BUG= R=rodolph.perfetta@arm.com Committed: https://code.google.com/p/v8/source/detail?r=18886

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -96 lines)			Patch
M	src/a64/lithium-a64.h	View	4 chunks	+26 lines, -29 lines	0 comments	Download
M	src/a64/lithium-a64.cc	View	1 chunk	+12 lines, -13 lines	0 comments	Download
M	src/a64/lithium-codegen-a64.cc	View	4 chunks	+25 lines, -54 lines	0 comments	Download
M	src/a64/macro-assembler-a64.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/a64/macro-assembler-a64.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

m.m.capewell

6 years, 10 months ago (2014-01-28 17:33:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18886 (presubmit successful).

Expand Messages | Collapse Messages