third_party/WebKit/Source/core/dom/Node.h - Issue 1482433003: Sync cloneNode() IDL with the spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Node.h

Issue 1482433003: Sync cloneNode() IDL with the spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Node.h

diff --git a/third_party/WebKit/Source/core/dom/Node.h b/third_party/WebKit/Source/core/dom/Node.h

index e7ab471e7bc892deb76006f49abc601c9c3f906a..18ea2ae7f70a1bec04a49125d91c7e877eb742e5 100644

--- a/third_party/WebKit/Source/core/dom/Node.h

+++ b/third_party/WebKit/Source/core/dom/Node.h

@@ -228,7 +228,7 @@ public:

PassRefPtrWillBeRawPtr<Node> appendChild(PassRefPtrWillBeRawPtr<Node> newChild, ExceptionState& = ASSERT_NO_EXCEPTION);

bool hasChildren() const { return firstChild(); }

- virtual PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = false) = 0;

+ virtual PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep) = 0;

void normalize();

bool isSameNode(Node* other) const { return this == other; }