Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
148243011:
Aura: Don't create GL context for GetSharedSurfaceHandle() (Closed)
|
Created:
6 years, 10 months ago by no sievers Modified:
6 years, 10 months ago CC:
chromium-reviews, joi+watch-content_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionAura: Don't create GL context for GetSharedSurfaceHandle()
BUG=329737
NOTRY=True
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249564
Patch Set 1 #
Messages
Total messages: 19 (0 generated)
Maybe time for another attempt.... It has the side-effect of not getting lost context callbacks until somebody uses (and creates) the main thread contexts. But that entirely makes sense, since we only should care about resources that were created in that context as far as that callback is concerned. (Also, regarding the tests that were failing last time - none of them were logging a lost UI resource context in passing runs.)
Hopeful LGTM
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/148243011/1
Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/148243011/1
Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
The CQ bit was checked by sievers@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/148243011/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...
The CQ bit was checked by danakj@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/148243011/1
The CQ bit was unchecked by sievers@chromium.org
The CQ bit was checked by sievers@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because the description was changed between the time the change entered the commit queue and the time it was ready to commit. You can safely check the commit box again.
The CQ bit was checked by sievers@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/148243011/1
Message was sent while issue was closed.
Change committed as 249564 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
