Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 148243010: Mark RTL iFrame tests on Mac as expected failure (baselines are wrong). (Closed)

Created:
6 years, 10 months ago by wjmaclean
Modified:
6 years, 10 months ago
Reviewers:
enne (OOO)
CC:
blink-reviews
Visibility:
Public.

Description

Mark RTL iFrame tests on Mac as expected failure (baselines are wrong). The existing Mac-only baselines are wrong, and need to be fixed to work with the new composited scrollbar framework. BUG=338794 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165970

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +14 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wjmaclean
I'm assuming there's no "!Mac" syntax for TestExpectations? Some of these tests are already marked ...
6 years, 10 months ago (2014-01-28 19:57:07 UTC) #1
enne (OOO)
That's what you gotta do in TestExpectations land, unfortunately. lgtm
6 years, 10 months ago (2014-01-28 20:34:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/148243010/1
6 years, 10 months ago (2014-01-28 20:36:55 UTC) #3
commit-bot: I haz the power
Change committed as 165970
6 years, 10 months ago (2014-01-28 22:24:14 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-28 22:25:23 UTC) #5
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698