Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1482363003: Fix ExploitabilityLinuxUtilsTest::DisassembleBytesTest to not fail when temp file ends with 0 (Closed)

Created:
5 years ago by Ted Mielczarek
Modified:
5 years ago
Reviewers:
ivanpe
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix ExploitabilityLinuxUtilsTest::DisassembleBytesTest to not fail when temp file ends with 0 R=ivanpe@chromium.org BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=668 Committed: https://chromium.googlesource.com/breakpad/breakpad/+/86d5e9e7f94a9cc90c9fe90584d7c8eda6057d17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/processor/exploitability_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Ted Mielczarek
5 years ago (2015-11-30 17:59:56 UTC) #1
Ted Mielczarek
In case it's not clear, the objdump output looks like: ``` /tmp/whatever: file format binary ...
5 years ago (2015-11-30 18:34:04 UTC) #2
ivanpe
On 2015/11/30 18:34:04, Ted Mielczarek wrote: > In case it's not clear, the objdump output ...
5 years ago (2015-11-30 18:56:21 UTC) #3
Ted Mielczarek
5 years ago (2015-11-30 19:05:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
86d5e9e7f94a9cc90c9fe90584d7c8eda6057d17 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698