Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: src/processor/exploitability_unittest.cc

Issue 1482363003: Fix ExploitabilityLinuxUtilsTest::DisassembleBytesTest to not fail when temp file ends with 0 (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/processor/exploitability_unittest.cc
diff --git a/src/processor/exploitability_unittest.cc b/src/processor/exploitability_unittest.cc
index 700f9e58cc59ab634bc910a27c4099d5236a38ad..dc5650e3890dd69d8b3ae1b468d3f0ce0a4e8932 100644
--- a/src/processor/exploitability_unittest.cc
+++ b/src/processor/exploitability_unittest.cc
@@ -194,8 +194,10 @@ TEST(ExploitabilityLinuxUtilsTest, DisassembleBytesTest) {
std::stringstream objdump_stream;
objdump_stream.str(string(buffer));
string line = "";
- while ((line.find("0:") == string::npos) && getline(objdump_stream, line)) {
+ while ((line.find("<.data>") == string::npos) &&
+ getline(objdump_stream, line)) {
}
+ ASSERT_TRUE(getline(objdump_stream, line));
ASSERT_EQ(line, " 0:\tc7 00 05 00 00 00 \tmov DWORD PTR [rax],0x5");
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698