Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5298)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

Issue 148233008: Grant Files.app access for mount points added after its launch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
index d3729e1591fb0e86d3bf52b120426b746d47bab4..eed428036a884499e5bf79da5f09a494bf219df5 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
@@ -52,10 +52,8 @@ void SetDriveMountPointPermissions(
Profile* profile,
const std::string& extension_id,
hashimoto 2014/01/28 10:55:13 nit: This is not used.
kinaba 2014/01/28 23:59:49 Done.
content::RenderViewHost* render_view_host) {
- if (!render_view_host ||
- !render_view_host->GetSiteInstance() || !render_view_host->GetProcess()) {
+ if (!render_view_host || !render_view_host->GetProcess())
return;
- }
fileapi::ExternalFileSystemBackend* backend =
file_manager::util::GetFileSystemContextForRenderViewHost(
@@ -68,10 +66,6 @@ void SetDriveMountPointPermissions(
// expects this to be satisfied.
ChildProcessSecurityPolicy::GetInstance()->GrantCreateReadWriteFile(
render_view_host->GetProcess()->GetID(), mount_point);
kinaba 2014/01/28 23:59:49 Since now this is the only line executed in this f
-
- base::FilePath mount_point_virtual;
- if (backend->GetVirtualPath(mount_point, &mount_point_virtual))
- backend->GrantFileAccessToExtension(extension_id, mount_point_virtual);
}
// Retrieves total and remaining available size on |mount_path|.

Powered by Google App Engine
This is Rietveld 408576698