Grant Files.app access for mount points added after its launch.

chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_manager/private_api_file_system.h"
 
 #include <sys/statvfs.h>
 
 #include "base/posix/eintr_wrapper.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 32 matching lines @@
 using fileapi::FileSystemURL;
 
 namespace extensions {
 namespace {
 
 // Sets permissions for the Drive mount point so Files.app can access files
 // in the mount point directory. It's safe to call this function even if
 // Drive is disabled by the setting (i.e. prefs::kDisableDrive is true).
 void SetDriveMountPointPermissions(
     Profile* profile,
     const std::string& extension_id,

[hashimoto, 2014/01/28 10:55:13]

nit: This is not used.

[kinaba, 2014/01/28 23:59:49]

Done.

     content::RenderViewHost* render_view_host) {
-  if (!render_view_host ||
-      !render_view_host->GetSiteInstance() || !render_view_host->GetProcess()) {
+  if (!render_view_host || !render_view_host->GetProcess())
     return;
-  }
 
   fileapi::ExternalFileSystemBackend* backend =
       file_manager::util::GetFileSystemContextForRenderViewHost(
           profile, render_view_host)->external_backend();
   if (!backend)

[hashimoto, 2014/01/28 10:55:13]

nit: This code seems unnecessary because |backend| is not used and the same
check is performed by
FileBrowserPrivateRequestFileSystemFunction::SetupFileSystemAccessPermissions().

[kinaba, 2014/01/28 23:59:49]

Done.

     return;
 
   const base::FilePath mount_point = drive::util::GetDriveMountPointPath();
   // Grant R/W permissions to drive 'folder'. File API layer still

[hashimoto, 2014/01/28 10:55:13]

nit: What does 'still' mean?

[kinaba, 2014/01/28 23:59:49]

Just my guess but it's even though we grant permissions by
backend->GrantFileAccess but still needs something elsewhere...

   // expects this to be satisfied.
   ChildProcessSecurityPolicy::GetInstance()->GrantCreateReadWriteFile(
       render_view_host->GetProcess()->GetID(), mount_point);

[kinaba, 2014/01/28 23:59:49]

Since now this is the only line executed in this function, I simply inlined it
to the caller.

-
-  base::FilePath mount_point_virtual;
-  if (backend->GetVirtualPath(mount_point, &mount_point_virtual))
-    backend->GrantFileAccessToExtension(extension_id, mount_point_virtual);
 }
 
 // Retrieves total and remaining available size on |mount_path|.
 void GetSizeStatsOnBlockingPool(const std::string& mount_path,
                                 uint64* total_size,
                                 uint64* remaining_size) {
   struct statvfs stat = {};  // Zero-clear
   if (HANDLE_EINTR(statvfs(mount_path.c_str(), &stat)) == 0) {
     *total_size = static_cast<uint64>(stat.f_blocks) * stat.f_frsize;
     *remaining_size = static_cast<uint64>(stat.f_bavail) * stat.f_frsize;
@@ skipping 488 matching lines @@
   // We don't much take care about the result of cancellation.
   BrowserThread::PostTask(
       BrowserThread::IO,
       FROM_HERE,
       base::Bind(&CancelCopyOnIOThread, file_system_context, params->copy_id));
   SendResponse(true);
   return true;
 }
 
 }  // namespace extensions